All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@ni.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [WORKING PATCH 1/2] sandbox: Use defconfig to enable features
Date: Wed, 6 May 2015 12:54:03 -0500	[thread overview]
Message-ID: <1430934844-9578-1-git-send-email-joe.hershberger@ni.com> (raw)
In-Reply-To: <CAPnjgZ1kND0QqhGP96_JzCe5=HWAgZjDJB-JqT5RAonWCZ3Fag@mail.gmail.com>

Stop using the sandbox arch Kconfig to override defaults for config
options. This is a bit of abuse and may be causing build problems.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
---
The errors you are seeing are the result of "CONFIG_UNIT_TEST" not being
defined. That should not be at all related to that test/dm/eth.c patch.
This is changing the way that CONFIG_UNIT_TEST is enabled to be more
typical in case there is some bad behavior with all this override of
defaults. I have seen some non-ideal behavior, so I want to move away
from using it.
Please apply this on top of u-boot-dm/env-working and try it.

 arch/sandbox/Kconfig      | 18 ------------------
 configs/sandbox_defconfig |  5 +++++
 2 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig
index 4647d11..f078c9e 100644
--- a/arch/sandbox/Kconfig
+++ b/arch/sandbox/Kconfig
@@ -10,12 +10,6 @@ config SYS_BOARD
 config SYS_CONFIG_NAME
 	default "sandbox"
 
-config UNIT_TEST
-	default y
-
-config UT_DM
-	default y
-
 config PCI
 	bool "PCI support"
 	help
@@ -23,16 +17,4 @@ config PCI
 	  used on some devices to allow the CPU to communicate with its
 	  peripherals.
 
-config NET
-	default y
-
-config NETDEVICES
-	default y
-
-config DM_ETH
-	default y
-
-config ETH_SANDBOX_RAW
-	default y
-
 endmenu
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index 3ac0a5a..65002f7 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -10,12 +10,15 @@ CONFIG_FIT_SIGNATURE=y
 CONFIG_CMD_SOUND=y
 CONFIG_OF_CONTROL=y
 CONFIG_OF_HOSTFILE=y
+CONFIG_NET=y
 CONFIG_DM_PCI=y
 CONFIG_PCI_SANDBOX=y
 CONFIG_SPI_FLASH_SANDBOX=y
 CONFIG_CMD_CROS_EC=y
 CONFIG_CROS_EC=y
 CONFIG_CROS_EC_SANDBOX=y
+CONFIG_DM_ETH=y
+CONFIG_NETDEVICES=y
 CONFIG_CROS_EC_KEYB=y
 CONFIG_TPM_TIS_SANDBOX=y
 CONFIG_SYS_I2C_SANDBOX=y
@@ -27,4 +30,6 @@ CONFIG_USB=y
 CONFIG_USB_EMUL=y
 CONFIG_USB_STORAGE=y
 CONFIG_DM_RTC=y
+CONFIG_UNIT_TEST=y
+CONFIG_UT_DM=y
 CONFIG_UT_ENV=y
-- 
1.7.11.5

  reply	other threads:[~2015-05-06 17:54 UTC|newest]

Thread overview: 196+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 22:02 [U-Boot] [PATCH 00/11] Improve env var handling for net stack Joe Hershberger
2015-04-21 22:02 ` [U-Boot] [PATCH 01/11] sandbox: Enable some ENV commands Joe Hershberger
2015-04-24  4:33   ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 02/11] kconfig: Move REGEX to Kconfig Joe Hershberger
2015-04-24  4:33   ` Simon Glass
2015-05-10 14:07   ` [U-Boot] [U-Boot,02/11] " Tom Rini
2015-05-10 18:05     ` Joe Hershberger
2015-05-10 18:30       ` Tom Rini
2015-04-21 22:02 ` [U-Boot] [PATCH 03/11] sandbox: Enable regex support Joe Hershberger
2015-04-24  4:33   ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 04/11] env: Fix return values in env_attr_lookup() Joe Hershberger
2015-04-24  4:33   ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 05/11] env: Simplify the reverse_strstr() interface Joe Hershberger
2015-04-24  4:34   ` Simon Glass
2015-04-27 19:24     ` Joe Hershberger
2015-04-27 19:31       ` Joe Hershberger
2015-04-27 19:58         ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 06/11] env: Allow env_attr_walk to pass a priv * to callback Joe Hershberger
2015-04-21 22:20   ` Joe Hershberger
2015-04-24  4:34     ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 07/11] env: Add regex support to env_attrs Joe Hershberger
2015-04-24  4:34   ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 08/11] env: Distinguish finer between source of env change Joe Hershberger
2015-04-24  4:34   ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 09/11] net: Apply default format rules to all ethaddr Joe Hershberger
2015-04-24  4:34   ` Simon Glass
2015-04-27 19:35     ` Joe Hershberger
2015-04-27 19:59       ` Simon Glass
2015-04-21 22:02 ` [U-Boot] [PATCH 10/11] net: Use env callbacks for net variables Joe Hershberger
2015-04-24  4:34   ` Simon Glass
2015-04-27 19:38     ` Joe Hershberger
2015-04-21 22:02 ` [U-Boot] [PATCH 11/11] net: Add default flags for common net env vars Joe Hershberger
2015-04-24  4:35   ` Simon Glass
2015-04-24  4:32 ` [U-Boot] [PATCH 00/11] Improve env var handling for net stack Simon Glass
2015-04-27 18:20   ` Joe Hershberger
2015-04-27 19:53     ` Simon Glass
2015-04-27 20:07       ` Joe Hershberger
2015-04-29  5:50 ` [U-Boot] [PATCH v2 00/19] " Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 01/19] sandbox: Enable some ENV commands Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 02/19] kconfig: Move REGEX to Kconfig Joe Hershberger
2015-04-29  5:59     ` Stefan Roese
2015-04-29  5:50   ` [U-Boot] [PATCH v2 03/19] sandbox: Enable regex support Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 04/19] env: Fix return values in env_attr_lookup() Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 05/19] env: Simplify the reverse_strstr() interface Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 06/19] env: Allow env_attr_walk to pass a priv * to callback Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 07/19] env: Add regex support to env_attrs Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 08/19] env: Distinguish finer between source of env change Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 09/19] net: Apply default format rules to all ethaddr Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 10/19] net: Use env callbacks for net variables Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 11/19] net: Add default flags for common net env vars Joe Hershberger
2015-04-29  5:50   ` [U-Boot] [PATCH v2 12/19] test: Generalize the unit test framework Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-04-29  5:51   ` [U-Boot] [PATCH v2 13/19] test: dm: Don't bail on all tests if one test fails Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-04-29  5:51   ` [U-Boot] [PATCH v2 14/19] test: Return values from the asserts compatible with cmds Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-04-29  5:51   ` [U-Boot] [PATCH v2 15/19] test: env: Add test framework for env Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-04-29  5:51   ` [U-Boot] [PATCH v2 16/19] test: env: Add test for verifying env attrs Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-05-03 20:16       ` Joe Hershberger
2015-04-29  5:51   ` [U-Boot] [PATCH v2 17/19] test: env: Add a test of the new regex behavior for attrs Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-04-29  5:51   ` [U-Boot] [PATCH v2 18/19] sandbox: Cleanup order and extra defines in defconfig Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-04-29  5:51   ` [U-Boot] [PATCH v2 19/19] sandbox: Enable env unit tests Joe Hershberger
2015-05-01  3:46     ` Simon Glass
2015-05-03 20:12   ` [U-Boot] [PATCH v3 00/26] Improve env var handling for net stack Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 01/26] sandbox: Enable some ENV commands Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 02/26] kconfig: Move REGEX to Kconfig Joe Hershberger
2015-05-04  8:18       ` Pavel Machek
2015-05-03 20:12     ` [U-Boot] [PATCH v3 03/26] sandbox: Enable regex support Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 04/26] env: Fix return values in env_attr_lookup() Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 05/26] env: Simplify the reverse_strstr() interface Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 06/26] env: Allow env_attr_walk to pass a priv * to callback Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 07/26] env: Add regex support to env_attrs Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 08/26] env: Distinguish finer between source of env change Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 09/26] net: Apply default format rules to all ethaddr Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 10/26] net: Use env callbacks for net variables Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 11/26] net: Add default flags for common net env vars Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 12/26] net: Remove duplicate bootfile syncing functionality Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 13/26] net: Handle ethaddr changes as an env callback Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 14/26] test: Generalize the unit test framework Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 15/26] test: Add a common unit test command Joe Hershberger
2015-05-05 20:56       ` Simon Glass
2015-05-03 20:12     ` [U-Boot] [PATCH v3 16/26] test: Move the unit tests to their own menu Joe Hershberger
2015-05-05 20:56       ` Simon Glass
2015-05-03 20:12     ` [U-Boot] [PATCH v3 17/26] test: dm: Don't bail on all tests if one test fails Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 18/26] test: dm: eth: Handle failed test env cleanup Joe Hershberger
2015-05-05 20:56       ` Simon Glass
2015-05-05 23:39         ` Joe Hershberger
2015-05-06 15:11           ` Simon Glass
2015-05-06 15:39             ` Joe Hershberger
2015-05-06 15:59               ` Simon Glass
2015-05-06 17:54                 ` Joe Hershberger [this message]
2015-05-06 17:54                   ` [U-Boot] [WORKING PATCH 2/2] fixup! " Joe Hershberger
2015-05-06 22:00                   ` [U-Boot] [WORKING PATCH 1/2] sandbox: Use defconfig to enable features Simon Glass
2015-05-07  8:39                     ` Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 19/26] test: Return values from the asserts compatible with cmds Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 20/26] test: dm: Recover the driver model tree after tests Joe Hershberger
2015-05-05 20:58       ` Simon Glass
2015-05-03 20:12     ` [U-Boot] [PATCH v3 21/26] test: env: Add test framework for env Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 22/26] test: env: Add test for verifying env attrs Joe Hershberger
2015-05-03 20:12     ` [U-Boot] [PATCH v3 23/26] test: env: Add a test of the new regex behavior for attrs Joe Hershberger
2015-05-03 20:13     ` [U-Boot] [PATCH v3 24/26] test: dm: Move the dm tests over to the ut command Joe Hershberger
2015-05-05 20:58       ` Simon Glass
2015-05-03 20:13     ` [U-Boot] [PATCH v3 25/26] sandbox: Cleanup order and extra defines in defconfig Joe Hershberger
2015-05-03 20:13     ` [U-Boot] [PATCH v3 26/26] sandbox: Enable env unit tests Joe Hershberger
2015-05-04 18:34     ` [U-Boot] [PATCH v3 00/26] Improve env var handling for net stack Joe Hershberger
2015-05-07  9:48     ` [U-Boot] [PATCH v4 " Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 01/26] sandbox: Cleanup order and extra defines in defconfig Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 02/26] sandbox: Use defconfig to enable features Joe Hershberger
2015-05-08 17:36         ` Simon Glass
2015-05-07  9:48       ` [U-Boot] [PATCH v4 03/26] sandbox: Enable some ENV commands Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 04/26] kconfig: Move REGEX to Kconfig Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 05/26] env: Fix return values in env_attr_lookup() Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 06/26] env: Simplify the reverse_strstr() interface Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 07/26] env: Allow env_attr_walk to pass a priv * to callback Joe Hershberger
2015-05-07  9:48       ` [U-Boot] [PATCH v4 08/26] env: Add regex support to env_attrs Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 09/26] env: Distinguish finer between source of env change Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 10/26] net: Apply default format rules to all ethaddr Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 11/26] net: Use env callbacks for net variables Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 12/26] net: Add default flags for common net env vars Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 13/26] net: Remove duplicate bootfile syncing functionality Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 14/26] net: Handle ethaddr changes as an env callback Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 15/26] test: Generalize the unit test framework Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 16/26] test: Add a common unit test command Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 17/26] test: dm: Move the dm tests over to the ut command Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 18/26] test: Move the unit tests to their own menu Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 19/26] test: dm: Don't bail on all tests if one test fails Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 20/26] test: dm: eth: Handle failed test env cleanup Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 21/26] test: Return values from the asserts compatible with cmds Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 22/26] test: dm: Recover the driver model tree after tests Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 23/26] test: env: Add test framework for env Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 24/26] test: env: Add test for verifying env attrs Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 25/26] test: env: Add a test of the new regex behavior for attrs Joe Hershberger
2015-05-07  9:49       ` [U-Boot] [PATCH v4 26/26] sandbox: Enable env unit tests Joe Hershberger
2015-05-07 22:29       ` [U-Boot] [PATCH v4 00/26] Improve env var handling for net stack Simon Glass
2015-05-19 20:24       ` Joe Hershberger
2015-05-20 14:58       ` Tom Rini
2015-05-20 19:27         ` [U-Boot] [PATCH v5 " Joe Hershberger
2015-05-20 19:27           ` [U-Boot] [PATCH v5 01/26] sandbox: Cleanup order and extra defines in defconfig Joe Hershberger
2015-05-23 12:39             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 02/26] sandbox: Use defconfig to enable features Joe Hershberger
2015-05-23 12:39             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 03/26] sandbox: Enable some ENV commands Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 04/26] env: Fix return values in env_attr_lookup() Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 05/26] env: Simplify the reverse_strstr() interface Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 06/26] env: Allow env_attr_walk to pass a priv * to callback Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 07/26] env: Add regex support to env_attrs Joe Hershberger
2015-05-23 12:42             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 08/26] env: Distinguish finer between source of env change Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 09/26] net: Apply default format rules to all ethaddr Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 10/26] net: Use env callbacks for net variables Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 11/26] net: Add default flags for common net env vars Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 12/26] net: Remove duplicate bootfile syncing functionality Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 13/26] net: Handle ethaddr changes as an env callback Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 14/26] test: Generalize the unit test framework Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 15/26] test: Add a common unit test command Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 16/26] test: dm: Move the dm tests over to the ut command Joe Hershberger
2015-05-23 12:40             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 17/26] test: dm: Move the time test " Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 18/26] test: Move the unit tests to their own menu Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 19/26] test: dm: Don't bail on all tests if one test fails Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 20/26] test: dm: eth: Handle failed test env cleanup Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 21/26] test: Return values from the asserts compatible with cmds Joe Hershberger
2015-05-23 12:42             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 22/26] test: dm: Recover the driver model tree after tests Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 23/26] test: env: Add test framework for env Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 24/26] test: env: Add test for verifying env attrs Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 25/26] test: env: Add a test of the new regex behavior for attrs Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:27           ` [U-Boot] [PATCH v5 26/26] sandbox: Enable env unit tests Joe Hershberger
2015-05-23 12:41             ` Tom Rini
2015-05-20 19:38         ` [U-Boot] [PATCH v4 00/26] Improve env var handling for net stack Joe Hershberger
2015-05-21 13:33           ` Tom Rini
2015-05-21 13:50             ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430934844-9578-1-git-send-email-joe.hershberger@ni.com \
    --to=joe.hershberger@ni.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.