From: Eryu Guan <eguan@redhat.com>
To: fstests@vger.kernel.org
Cc: Eryu Guan <eguan@redhat.com>
Subject: [PATCH v3] generic/081: wait for lv to be settled before creating fs on it
Date: Thu, 7 May 2015 11:33:43 +0800 [thread overview]
Message-ID: <1430969623-20789-1-git-send-email-eguan@redhat.com> (raw)
In-Reply-To: <1428054075-20780-1-git-send-email-eguan@redhat.com>
Call 'udevadm settle' or 'udevsettle' or 'sleep 1' to make sure new lv
is ready for use before making filesystem on it, depends on which
command is available on the system.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
v3:
- add fsync command back and no 'sleep 1' in cleanup either
v2:
- move UDEV_SETTLE_PROG setup code to common/config
- remove fsync from xfs_io command
- update comments a bit about waiting for lv creation
common/config | 18 ++++++++++++++++++
tests/generic/081 | 2 ++
2 files changed, 20 insertions(+)
diff --git a/common/config b/common/config
index 3732287..b7991ed 100644
--- a/common/config
+++ b/common/config
@@ -192,6 +192,24 @@ export DUMP_PROG="`set_prog_path dump`"
export RESTORE_PROG="`set_prog_path restore`"
export LVM_PROG="`set_prog_path lvm`"
+# use 'udevadm settle' or 'udevsettle' to wait for lv to be settled.
+# newer systems have udevadm command but older systems like RHEL5 don't.
+# But if neither one is available, just set it to "sleep 1" to wait for lv to
+# be settled
+UDEV_SETTLE_PROG="`set_prog_path udevadm`"
+if [ "$UDEV_SETTLE_PROG" == "" ]; then
+ # try udevsettle command
+ UDEV_SETTLE_PROG="`set_prog_path udevsettle`"
+else
+ # udevadm is available, add 'settle' as subcommand
+ UDEV_SETTLE_PROG="$UDEV_SETTLE_PROG settle"
+fi
+# neither command is available, use sleep 1
+if [ "$UDEV_SETTLE_PROG" == "" ]; then
+ UDEV_SETTLE_PROG="sleep 1"
+fi
+export UDEV_SETTLE_PROG
+
# Generate a comparable xfsprogs version number in the form of
# major * 10000 + minor * 100 + release
#
diff --git a/tests/generic/081 b/tests/generic/081
index 5d38c11..34da1ac 100755
--- a/tests/generic/081
+++ b/tests/generic/081
@@ -66,6 +66,8 @@ mkdir -p $mnt
_scratch_mkfs_sized $((300 * 1024 * 1024)) >>$seqres.full 2>&1
$LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1
$LVM_PROG lvcreate --yes -L 256M -n $lvname $vgname >>$seqres.full 2>&1
+# wait for lvcreation to fully complete
+$UDEV_SETTLE_PROG >>$seqres.full 2>&1
# _mkfs_dev exits the test on failure, this can make sure lv is created in
# above vgcreate/lvcreate steps
--
2.1.0
prev parent reply other threads:[~2015-05-07 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 9:41 [PATCH] generic/081: wait for lv to be settled before creating fs on it Eryu Guan
2015-05-04 6:27 ` Dave Chinner
2015-05-06 7:32 ` Eryu Guan
2015-05-06 7:58 ` [PATCH v2] " Eryu Guan
2015-05-06 23:13 ` [PATCH] " Dave Chinner
2015-05-07 3:11 ` Eryu Guan
2015-05-07 3:33 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430969623-20789-1-git-send-email-eguan@redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.