From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099AbbEGHjj (ORCPT ); Thu, 7 May 2015 03:39:39 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:60575 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbbEGHje (ORCPT ); Thu, 7 May 2015 03:39:34 -0400 From: Christoph Hellwig To: Jens Axboe Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: fix queue_lock usage in blk-mq and nvme Date: Thu, 7 May 2015 09:38:12 +0200 Message-Id: <1430984294-25859-1-git-send-email-hch@lst.de> X-Mailer: git-send-email 1.9.1 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Historically we always take queue_lock with irqs disabled. Blk-mq doesn't really use the queue_lock much, but when it does it needs to follow this rules to make lockdep happy. The first patch removes a queue_lock usage instead of fixing things properly, and the second is a bad-aid for nvme. In the long run I'd prefer to remove other users of the queue_lock from blk-mq and blk-mq based driver entirely, but that will require a bit more work. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 7 May 2015 09:38:12 +0200 Subject: fix queue_lock usage in blk-mq and nvme Message-ID: <1430984294-25859-1-git-send-email-hch@lst.de> Historically we always take queue_lock with irqs disabled. Blk-mq doesn't really use the queue_lock much, but when it does it needs to follow this rules to make lockdep happy. The first patch removes a queue_lock usage instead of fixing things properly, and the second is a bad-aid for nvme. In the long run I'd prefer to remove other users of the queue_lock from blk-mq and blk-mq based driver entirely, but that will require a bit more work.