From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Fam Zheng <famz@redhat.com>,
Yinghai Lu <yhlu.kernel.send@gmail.com>,
Yijing Wang <wangyijing@huawei.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH v6 0/2] pci: drop msi disable on shutdown
Date: Tue, 12 May 2015 15:03:10 +0200 [thread overview]
Message-ID: <1431431730-25164-1-git-send-email-mst@redhat.com> (raw)
Fam Zheng noticed that pci shutdown disables msi and msix of a device. This
was intended to fix kexec with fusion devices but is no longer necessary, and
can in theory be harmful.
See individual patches for the detailed explanation.
Please review, and consider for 4.2.
Eric, I would especially appreciate your feedback - I did my best
to update the commit logs with answers to questions you raised
on v5.
changes from v5:
rebased on top of pci/msi
fixed commit log, including comments by Bjorn
and adding explanation to address comments/questions by Eric
dropped stable Cc, this patch does not seem to qualify for stable
changes from v4:
Yijing Wang <wangyijing@huawei.com> noted that
early fixups rely on pci_msi_off.
Split out the functionality and move off the
required part to run early during pci_device_setup.
Changes from v3:
fix a copy-and-paste error in
pci: drop some duplicate code
other patches are unchanged
drop Cc stable for now
Changes from v2:
move code from probe to device enumeration
add patches to unexport pci_msi_off
Michael S. Tsirkin (2):
PCI/MSI: Don't disable MSI/MSI-X at shutdown
PCI/MSI: Make pci_msi_shutdown(), pci_msix_shutdown() static
include/linux/pci.h | 4 ----
drivers/pci/msi.c | 4 ++--
drivers/pci/pci-driver.c | 2 --
3 files changed, 2 insertions(+), 8 deletions(-)
--
MST
next reply other threads:[~2015-05-12 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 13:03 Michael S. Tsirkin [this message]
2015-05-12 13:03 ` [PATCH v6 1/2] PCI/MSI: Don't disable MSI/MSI-X at shutdown Michael S. Tsirkin
2015-05-12 19:22 ` Eric W. Biederman
2015-05-13 6:41 ` Michael S. Tsirkin
2015-05-14 6:06 ` Michael S. Tsirkin
2015-05-14 7:58 ` Eric W. Biederman
2015-05-14 9:53 ` Michael S. Tsirkin
2015-05-28 16:36 ` Michael S. Tsirkin
2015-06-03 18:37 ` Michael S. Tsirkin
2015-05-19 14:58 ` Bjorn Helgaas
2015-05-21 6:21 ` Fam Zheng
2015-05-12 13:03 ` [PATCH v6 2/2] PCI/MSI: Make pci_msi_shutdown(), pci_msix_shutdown() static Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431431730-25164-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=bhelgaas@google.com \
--cc=ebiederm@xmission.com \
--cc=famz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wangyijing@huawei.com \
--cc=yhlu.kernel.send@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.