From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST v6 07/24] Debian: add preseed_create_guest
	helper
Date: Tue, 12 May 2015 16:22:11 +0100
Message-ID: <1431444131.8263.180.camel@citrix.com>
References: <1430905605.2660.187.camel@citrix.com>
	<1430906213-30108-7-git-send-email-ian.campbell@citrix.com>
	<21842.6465.840584.327009@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21842.6465.840584.327009@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-05-12 at 16:16 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[OSSTEST v6 07/24] Debian: add preseed_create_guest helper"):
> > Creates a preseed file suitable for use in a PV guest
> ...
> > +    my $extra_packages;
> 
> Doesn't this need a value from somewhere ?

It's given one in "distros: support booting Debian PV (d-i installed)
guests with pvgrub." later on, which is clearly too late.

I'll move the definition and use to the patch which actually needs it.

> 
> The rest looks plausible.
> 
> Ian.