From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 02/14] libxc/save: Adjust stream-position callbacks for checkpointed streams Date: Wed, 13 May 2015 16:56:39 +0100 Message-ID: <1431532599.8263.346.camel@citrix.com> References: <1431482044-21286-1-git-send-email-yanghy@cn.fujitsu.com> <1431482044-21286-3-git-send-email-yanghy@cn.fujitsu.com> <1431531979.8263.341.camel@citrix.com> <5553722A.8080300@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5553722A.8080300@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, ian.jackson@eu.citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca, Yang Hongyang List-Id: xen-devel@lists.xenproject.org On Wed, 2015-05-13 at 16:47 +0100, Andrew Cooper wrote: > On 13/05/15 16:46, Ian Campbell wrote: > > On Wed, 2015-05-13 at 09:53 +0800, Yang Hongyang wrote: > >> From: Andrew Cooper > >> > >> There are some records which should only be sent once in the stream, and not > >> repeated for each checkpoint. {start,end}_of_stream() become per-checkpoint, > >> and a new start_of_stream() is introduced. > >> > >> There is no resulting change record order, but the X86_PV_INFO record is > >> identified as once per stream. Currently the X86_PV_P2M_FRAMES record is as > >> well, but this is because of an implementation bug and can move back to being > >> on an as-needed basis when fixed. > >> > >> In addition, a few minor adjustments of comments and layout. > >> > >> Signed-off-by: Andrew Cooper > > Subject to my finding a suitable documentation update further down the > > series: > > > > Acked-by: Ian Campbell > > What update are you expecting? X86_PV_INFO is already strictly defined > as "sent once" in the spec. Something defining a checkpointed stread.