From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsSyW-0005Cr-EG for qemu-devel@nongnu.org; Wed, 13 May 2015 05:29:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsSyV-0001v0-2s for qemu-devel@nongnu.org; Wed, 13 May 2015 05:29:12 -0400 From: Fam Zheng Date: Wed, 13 May 2015 17:28:18 +0000 Message-Id: <1431538099-3286-11-git-send-email-famz@redhat.com> In-Reply-To: <1431538099-3286-1-git-send-email-famz@redhat.com> References: <1431538099-3286-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com Signed-off-by: Fam Zheng --- blockdev.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index ae52d27..bd28183 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1649,6 +1649,7 @@ typedef struct BlockdevBackupState { BlockDriverState *bs; BlockJob *job; AioContext *aio_context; + Error *blocker; } BlockdevBackupState; static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) @@ -1685,6 +1686,10 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) } aio_context_acquire(state->aio_context); + state->bs = bs; + error_setg(&state->blocker, "blockdev-backup in progress"); + bdrv_op_block(bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); + qmp_blockdev_backup(backup->device, backup->target, backup->sync, backup->has_speed, backup->speed, @@ -1696,7 +1701,6 @@ static void blockdev_backup_prepare(BlkTransactionState *common, Error **errp) return; } - state->bs = bs; state->job = state->bs->job; } @@ -1715,6 +1719,10 @@ static void blockdev_backup_clean(BlkTransactionState *common) { BlockdevBackupState *state = DO_UPCAST(BlockdevBackupState, common, common); + if (state->bs) { + bdrv_op_unblock(state->bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); + error_free(state->blocker); + } if (state->aio_context) { aio_context_release(state->aio_context); } -- 2.4.0