From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 04/14] libxc/migration: Pass checkpoint information into the save algorithm. Date: Thu, 14 May 2015 12:17:46 +0100 Message-ID: <1431602266.13579.37.camel@citrix.com> References: <1431482044-21286-1-git-send-email-yanghy@cn.fujitsu.com> <1431482044-21286-5-git-send-email-yanghy@cn.fujitsu.com> <1431532169.8263.343.camel@citrix.com> <5553F455.80202@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5553F455.80202@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, eddie.dong@intel.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On Thu, 2015-05-14 at 09:03 +0800, Yang Hongyang wrote: > > On 05/13/2015 11:49 PM, Ian Campbell wrote: > > On Wed, 2015-05-13 at 09:53 +0800, Yang Hongyang wrote: > >> From: Andrew Cooper > > > > OOI how was this signalled to the old code? > > The old code check the callbacks "postcopy & checkpoint", > if the callbacks exists, it will call them which I think is > unreliable, so I add this flag to explicitly indicate a > checkpointed stream in the new code. However, it is backward > compatible, the legacy migration just don't know this flag > and will ignore it. That makes sense, thanks. I think it would be good to quickly mention this in the commit log. If there is no other reason to make a v7 then you can just reply to v6 with some text and I'll merge it in on commit.