All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	yunhong.jiang@intel.com, eddie.dong@intel.com,
	xen-devel@lists.xen.org, rshriram@cs.ubc.ca,
	ian.jackson@eu.citrix.com
Subject: Re: [PATCH v5 02/14] libxc/save: Adjust stream-position callbacks for checkpointed streams
Date: Thu, 14 May 2015 12:18:21 +0100	[thread overview]
Message-ID: <1431602301.13579.38.camel@citrix.com> (raw)
In-Reply-To: <5553FFDF.9010504@cn.fujitsu.com>

On Thu, 2015-05-14 at 09:52 +0800, Yang Hongyang wrote:
> 
> On 05/13/2015 11:56 PM, Ian Campbell wrote:
> > On Wed, 2015-05-13 at 16:47 +0100, Andrew Cooper wrote:
> >> On 13/05/15 16:46, Ian Campbell wrote:
> >>> On Wed, 2015-05-13 at 09:53 +0800, Yang Hongyang wrote:
> >>>> From: Andrew Cooper <andrew.cooper3@citrix.com>
> >>>>
> >>>> There are some records which should only be sent once in the stream, and not
> >>>> repeated for each checkpoint.  {start,end}_of_stream() become per-checkpoint,
> >>>> and a new start_of_stream() is introduced.
> >>>>
> >>>> There is no resulting change record order, but the X86_PV_INFO record is
> >>>> identified as once per stream.  Currently the X86_PV_P2M_FRAMES record is as
> >>>> well, but this is because of an implementation bug and can move back to being
> >>>> on an as-needed basis when fixed.
> >>>>
> >>>> In addition, a few minor adjustments of comments and layout.
> >>>>
> >>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>> Subject to my finding a suitable documentation update further down the
> >>> series:
> >>>
> >>> Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
> >>
> >> What update are you expecting?  X86_PV_INFO is already strictly defined
> >> as "sent once" in the spec.
> >
> > Something defining a checkpointed stread.
> 
> I think this is done in the 3rd patch? Can I take this ack?

Yes, thanks.

  reply	other threads:[~2015-05-14 11:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  1:53 [PATCH v5 00/14] Misc patches to aid migration v2 Remus support Yang Hongyang
2015-05-13  1:53 ` [PATCH v5 01/14] libxc/migration: Be rather stricter with illformed callers Yang Hongyang
2015-05-13 15:45   ` Ian Campbell
2015-05-13  1:53 ` [PATCH v5 02/14] libxc/save: Adjust stream-position callbacks for checkpointed streams Yang Hongyang
2015-05-13 15:46   ` Ian Campbell
2015-05-13 15:47     ` Andrew Cooper
2015-05-13 15:56       ` Ian Campbell
2015-05-14  1:52         ` Yang Hongyang
2015-05-14 11:18           ` Ian Campbell [this message]
2015-05-13  1:53 ` [PATCH v5 03/14] libxc/migration: Specification update for CHECKPOINT records Yang Hongyang
2015-05-13 15:48   ` Ian Campbell
2015-05-13  1:53 ` [PATCH v5 04/14] libxc/migration: Pass checkpoint information into the save algorithm Yang Hongyang
2015-05-13 15:49   ` Ian Campbell
2015-05-14  1:03     ` Yang Hongyang
2015-05-14 11:17       ` Ian Campbell
2015-05-13  1:53 ` [PATCH v5 05/14] tools/libxc: unused attribute in DECLARE_HYPERCALL_BUFFER_SHADOW Yang Hongyang
2015-05-13 15:57   ` Ian Campbell
2015-05-14  1:06     ` Yang Hongyang
2015-05-13  1:53 ` [PATCH v5 06/14] tools/libxc: add a check in xc_hypercall_buffer_free_pages macro Yang Hongyang
2015-05-13  1:53 ` [PATCH v5 07/14] libxc/save: introduce setup() and cleanup() on save Yang Hongyang
2015-05-13  1:53 ` [PATCH v5 08/14] libxc/save: rename to_send to dirty_bitmap Yang Hongyang
2015-05-13  1:53 ` [PATCH v5 09/14] libxc/save: adjust the memory allocation for migration Yang Hongyang
2015-05-13  1:54 ` [PATCH v5 10/14] libxc/save: remove bitmap param from send_some_pages Yang Hongyang
2015-05-13  1:54 ` [PATCH v5 11/14] libxc/save: rename send_some_pages to send_dirty_pages Yang Hongyang
2015-05-13  1:54 ` [PATCH v5 12/14] libxc/save: reuse send_dirty_pages() in send_all_pages() Yang Hongyang
2015-05-13  1:54 ` [PATCH v5 13/14] libxc/restore: introduce process_record() Yang Hongyang
2015-05-13  1:54 ` [PATCH v5 14/14] libxc/restore: split read/handle qemu info Yang Hongyang
2015-05-13  7:54 ` [PATCH v5 00/14] Misc patches to aid migration v2 Remus support Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431602301.13579.38.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=wei.liu2@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.