All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Russell King <linux@arm.linux.org.uk>,
	ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
	tim@xen.org, linux-kernel@vger.kernel.org,
	Julien Grall <julien.grall@citrix.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [RFC 17/23] xen/grant-table: Make it running on 64KB granularity
Date: Thu, 14 May 2015 18:00:57 +0100	[thread overview]
Message-ID: <1431622863-28575-18-git-send-email-julien.grall__11919.6537336849$1431623960$gmane$org@citrix.com> (raw)
In-Reply-To: <1431622863-28575-1-git-send-email-julien.grall@citrix.com>

The Xen interface is using 4KB page granularity. This means that each
grant is 4KB.

The current implementation allocates a Linux page per grant. On Linux
using 64KB page granularity, only the first 4KB of the page will be
used.

We could decrease the memory wasted by sharing the page with multiple
grant. It will require some care with the {Set,Clear}ForeignPage macro.

Note that no changes has been made in the x86 code because both Linux
and Xen will only use 4KB page granularity.

Signed-off-by: Julien Grall <julien.grall@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
---
 arch/arm/xen/p2m.c        | 6 +++---
 drivers/xen/grant-table.c | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
index 887596c..0ed01f2 100644
--- a/arch/arm/xen/p2m.c
+++ b/arch/arm/xen/p2m.c
@@ -93,8 +93,8 @@ int set_foreign_p2m_mapping(struct gnttab_map_grant_ref *map_ops,
 	for (i = 0; i < count; i++) {
 		if (map_ops[i].status)
 			continue;
-		set_phys_to_machine(map_ops[i].host_addr >> PAGE_SHIFT,
-				    map_ops[i].dev_bus_addr >> PAGE_SHIFT);
+		set_phys_to_machine(map_ops[i].host_addr >> XEN_PAGE_SHIFT,
+				    map_ops[i].dev_bus_addr >> XEN_PAGE_SHIFT);
 	}
 
 	return 0;
@@ -108,7 +108,7 @@ int clear_foreign_p2m_mapping(struct gnttab_unmap_grant_ref *unmap_ops,
 	int i;
 
 	for (i = 0; i < count; i++) {
-		set_phys_to_machine(unmap_ops[i].host_addr >> PAGE_SHIFT,
+		set_phys_to_machine(unmap_ops[i].host_addr >> XEN_PAGE_SHIFT,
 				    INVALID_P2M_ENTRY);
 	}
 
diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 62f591f..dc0a787 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -642,7 +642,7 @@ int gnttab_setup_auto_xlat_frames(phys_addr_t addr)
 	if (xen_auto_xlat_grant_frames.count)
 		return -EINVAL;
 
-	vaddr = xen_remap(addr, PAGE_SIZE * max_nr_gframes);
+	vaddr = xen_remap(addr, XEN_PAGE_SIZE * max_nr_gframes);
 	if (vaddr == NULL) {
 		pr_warn("Failed to ioremap gnttab share frames (addr=%pa)!\n",
 			&addr);
@@ -654,7 +654,7 @@ int gnttab_setup_auto_xlat_frames(phys_addr_t addr)
 		return -ENOMEM;
 	}
 	for (i = 0; i < max_nr_gframes; i++)
-		pfn[i] = PFN_DOWN(addr) + i;
+		pfn[i] = XEN_PFN_DOWN(addr) + i;
 
 	xen_auto_xlat_grant_frames.vaddr = vaddr;
 	xen_auto_xlat_grant_frames.pfn = pfn;
@@ -978,7 +978,7 @@ static void gnttab_request_version(void)
 {
 	/* Only version 1 is used, which will always be available. */
 	grant_table_version = 1;
-	grefs_per_grant_frame = PAGE_SIZE / sizeof(struct grant_entry_v1);
+	grefs_per_grant_frame = XEN_PAGE_SIZE / sizeof(struct grant_entry_v1);
 	gnttab_interface = &gnttab_v1_ops;
 
 	pr_info("Grant tables using version %d layout\n", grant_table_version);
-- 
2.1.4

  parent reply	other threads:[~2015-05-14 17:18 UTC|newest]

Thread overview: 200+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 17:00 [RFC 00/23] arm64: Add support for 64KB page granularity in Xen guest Julien Grall
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00 ` [RFC 01/23] xen: Include xen/page.h rather than asm/xen/page.h Julien Grall
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 13:50   ` [Xen-devel] " David Vrabel
2015-05-19 13:50     ` David Vrabel
2015-05-19 13:50   ` David Vrabel
2015-05-14 17:00 ` [RFC 02/23] xen/xenbus: client: Fix call of virt_to_mfn in xenbus_grant_ring Julien Grall
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 13:51   ` David Vrabel
2015-05-19 13:51   ` [Xen-devel] " David Vrabel
2015-05-19 13:51     ` David Vrabel
2015-05-19 14:12     ` Julien Grall
2015-05-19 14:12     ` [Xen-devel] " Julien Grall
2015-05-19 14:12       ` Julien Grall
2015-05-14 17:00 ` [RFC 03/23] xen/grant-table: Remove unused macro SPP Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 13:52   ` [Xen-devel] " David Vrabel
2015-05-19 13:52     ` David Vrabel
2015-05-19 13:52   ` David Vrabel
2015-05-14 17:00 ` [RFC 04/23] block/xen-blkfront: Remove unused macro MAXIMUM_OUTSTANDING_BLOCK_REQS Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-20 14:36   ` Roger Pau Monné
2015-05-20 14:36   ` Roger Pau Monné
2015-05-20 14:36     ` Roger Pau Monné
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00 ` [RFC 05/23] block/xen-blkfront: Remove invalid comment Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-20 14:42   ` Roger Pau Monné
2015-05-20 14:42     ` Roger Pau Monné
2015-05-20 14:42     ` Roger Pau Monné
2015-05-14 17:00 ` [RFC 06/23] block/xen-blkback: s/nr_pages/nr_segs/ Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-20 14:54   ` Roger Pau Monné
2015-05-20 14:54     ` Roger Pau Monné
2015-05-20 14:54   ` Roger Pau Monné
2015-05-14 17:00 ` [RFC 07/23] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 13:53   ` [Xen-devel] " David Vrabel
2015-05-19 13:53     ` David Vrabel
2015-05-19 13:53   ` David Vrabel
2015-05-14 17:00 ` [RFC 08/23] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-15  0:26   ` Wei Liu
2015-05-15  0:26   ` Wei Liu
2015-05-15  0:26     ` Wei Liu
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00 ` [RFC 09/23] arm/xen: Drop duplicate define mfn_to_virt Julien Grall
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-06-23 13:25   ` Stefano Stabellini
2015-06-23 13:25   ` Stefano Stabellini
2015-06-23 13:25     ` Stefano Stabellini
2015-06-23 13:53     ` Julien Grall
2015-06-23 13:53     ` [Xen-devel] " Julien Grall
2015-06-23 13:53       ` Julien Grall
2015-05-14 17:00 ` [RFC 10/23] xen/biomerge: WORKAROUND always says the biovec are not mergeable Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-15 15:54   ` Boris Ostrovsky
2015-05-15 15:54   ` Boris Ostrovsky
2015-05-15 15:54     ` Boris Ostrovsky
2015-05-19 14:16     ` Julien Grall
2015-05-19 14:16       ` Julien Grall
2015-05-19 14:16     ` Julien Grall
2015-05-14 17:00 ` [RFC 11/23] xen: Add Xen specific page definition Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00 ` [RFC 12/23] xen: Extend page_to_mfn to take an offset in the page Julien Grall
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 13:57   ` David Vrabel
2015-05-19 13:57   ` [Xen-devel] " David Vrabel
2015-05-19 13:57     ` David Vrabel
2015-05-19 14:18     ` Julien Grall
2015-05-19 14:18       ` Julien Grall
2015-05-19 14:18     ` Julien Grall
2015-05-14 17:00 ` [RFC 13/23] xen/xenbus: Use Xen page definition Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 13:59   ` David Vrabel
2015-05-19 13:59   ` [Xen-devel] " David Vrabel
2015-05-19 13:59     ` David Vrabel
2015-05-19 14:19     ` Julien Grall
2015-05-19 14:19     ` [Xen-devel] " Julien Grall
2015-05-19 14:19       ` Julien Grall
2015-05-14 17:00 ` [RFC 14/23] tty/hvc: xen: Use xen " Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00 ` [RFC 15/23] xen/balloon: Don't rely on the page granularity is the same for Xen and Linux Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 15:23   ` [Xen-devel] " David Vrabel
2015-05-19 15:23     ` David Vrabel
2015-05-19 15:23   ` David Vrabel
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00 ` [RFC 16/23] xen/events: fifo: Make it running on 64KB granularity Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 15:25   ` David Vrabel
2015-05-19 15:25   ` [Xen-devel] " David Vrabel
2015-05-19 15:25     ` David Vrabel
2015-05-14 17:00 ` Julien Grall [this message]
2015-05-14 17:00 ` [RFC 17/23] xen/grant-table: " Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-19 15:27   ` [Xen-devel] " David Vrabel
2015-05-19 15:27     ` David Vrabel
2015-05-19 15:27   ` David Vrabel
2015-05-14 17:00 ` [RFC 18/23] block/xen-blkfront: Make it running on 64KB page granularity Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:00 ` [RFC 19/23] block/xen-blkback: " Julien Grall
2015-05-14 17:00 ` Julien Grall
2015-05-14 17:00   ` Julien Grall
2015-05-14 17:01 ` [RFC 20/23] net/xen-netfront: " Julien Grall
2015-05-14 17:01 ` Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-05-14 17:01 ` [RFC 21/23] net/xen-netback: " Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-05-15  2:35   ` Wei Liu
2015-05-15  2:35     ` Wei Liu
2015-05-15 12:35     ` [Xen-devel] " Julien Grall
2015-05-15 12:35       ` Julien Grall
2015-05-15 15:31       ` Wei Liu
2015-05-15 15:31         ` Wei Liu
2015-05-15 15:41         ` Ian Campbell
2015-05-15 15:41           ` Ian Campbell
2015-05-15 15:41         ` Ian Campbell
2015-05-18 12:11         ` [Xen-devel] " Julien Grall
2015-05-18 12:11           ` Julien Grall
2015-05-18 12:54           ` Wei Liu
2015-05-18 12:54           ` [Xen-devel] " Wei Liu
2015-05-18 12:54             ` Wei Liu
2015-05-19 22:56             ` Julien Grall
2015-05-19 22:56             ` [Xen-devel] " Julien Grall
2015-05-19 22:56               ` Julien Grall
2015-05-20  8:26               ` Wei Liu
2015-05-20  8:26               ` [Xen-devel] " Wei Liu
2015-05-20  8:26                 ` Wei Liu
2015-05-20 14:26                 ` Julien Grall
2015-05-20 14:26                   ` Julien Grall
2015-05-20 14:26                 ` Julien Grall
2015-05-20 14:29               ` Julien Grall
2015-05-20 14:29               ` [Xen-devel] " Julien Grall
2015-05-20 14:29                 ` Julien Grall
2015-05-18 12:11         ` Julien Grall
2015-05-15 15:31       ` Wei Liu
2015-05-15 12:35     ` Julien Grall
2015-05-15  2:35   ` Wei Liu
2015-05-14 17:01 ` [RFC 22/23] xen/privcmd: Add support for Linux " Julien Grall
2015-05-14 17:01 ` Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-05-19 15:39   ` David Vrabel
2015-05-19 15:39   ` [Xen-devel] " David Vrabel
2015-05-19 15:39     ` David Vrabel
2015-06-18 17:05     ` Julien Grall
2015-06-18 17:05     ` [Xen-devel] " Julien Grall
2015-06-18 17:05       ` Julien Grall
2015-05-14 17:01 ` [RFC 23/23] arm/xen: Add support for " Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-05-14 17:01   ` Julien Grall
2015-06-23 14:19   ` Stefano Stabellini
2015-06-23 14:19   ` Stefano Stabellini
2015-06-23 14:19     ` Stefano Stabellini
2015-06-23 14:37     ` Julien Grall
2015-06-23 14:37     ` Julien Grall
2015-06-23 14:37       ` Julien Grall
2015-06-23 14:49       ` Stefano Stabellini
2015-06-23 14:49       ` Stefano Stabellini
2015-06-23 14:49         ` Stefano Stabellini
2015-06-23 15:02         ` [Xen-devel] " Julien Grall
2015-06-23 15:02           ` Julien Grall
2015-06-23 16:12           ` Stefano Stabellini
2015-06-23 16:12           ` [Xen-devel] " Stefano Stabellini
2015-06-23 16:12             ` Stefano Stabellini
2015-06-23 15:02         ` Julien Grall
2015-05-15 15:45 ` [RFC 00/23] arm64: Add support for 64KB page granularity in Xen guest David Vrabel
2015-05-15 15:45 ` [Xen-devel] " David Vrabel
2015-05-15 15:45   ` David Vrabel
2015-05-15 15:51   ` Boris Ostrovsky
2015-05-15 15:51   ` [Xen-devel] " Boris Ostrovsky
2015-05-15 15:51     ` Boris Ostrovsky
2015-05-18 12:23   ` Julien Grall
2015-05-18 12:23   ` [Xen-devel] " Julien Grall
2015-05-18 12:23     ` Julien Grall
2015-06-23 13:37     ` Stefano Stabellini
2015-06-23 13:37     ` [Xen-devel] " Stefano Stabellini
2015-06-23 13:37       ` Stefano Stabellini
2015-06-23 13:41       ` Stefano Stabellini
2015-06-23 13:41       ` [Xen-devel] " Stefano Stabellini
2015-06-23 13:41         ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1431622863-28575-18-git-send-email-julien.grall__11919.6537336849$1431623960$gmane$org@citrix.com' \
    --to=julien.grall@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.