From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755494AbbESJgH (ORCPT ); Tue, 19 May 2015 05:36:07 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:55801 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829AbbESJgE (ORCPT ); Tue, 19 May 2015 05:36:04 -0400 Message-ID: <1432028159.9091.63.camel@x220> Subject: Re: [PATCH 1/3] kernel: Add a new config option to remove command line parsing From: Paul Bolle To: Iulia Manda Cc: tim.bird@sonymobile.com, linux-kernel@vger.kernel.org, josh@joshtriplett.org Date: Tue, 19 May 2015 11:35:59 +0200 In-Reply-To: <1431949832-13606-1-git-send-email-iulia.manda21@gmail.com> References: <1431949832-13606-1-git-send-email-iulia.manda21@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-05-18 at 14:50 +0300, Iulia Manda wrote: > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > +config CMDLINE_PARSE > + bool "Enable support for command line parsing" > + default y > + ---help--- > + With this option set to 'Y', kernel parameters, both the ones > + passed at boot time and at compile time are parsed. > + > + If you say no here, all the kernel parameters' values will be set > + to their defaults at compile time, in order to make constant > + folding possible. > + > + Systems with no space constraints should leave this option set to > + 'Y'. This adds a x86 specific Kconfig option. > --- a/include/linux/moduleparam.h > +++ b/include/linux/moduleparam.h > +#ifdef CONFIG_CMDLINE_PARSE > /* Called on module insert or kernel boot */ > extern char *parse_args(const char *name, > char *args, > @@ -359,6 +360,19 @@ extern char *parse_args(const char *name, > s16 level_max, > int (*unknown)(char *param, char *val, > const char *doing)); > +#else > +static inline char *parse_args(const char *name, > + char *args, > + const struct kernel_param *params, > + unsigned num, > + s16 level_min, > + s16 level_max, > + int (*unknown)(char *param, char *val, > + const char *doing)) > +{ > + return NULL; > +} > +#endif So this effectively disables parse_args() for all architectures, doesn't it? If that's OK, I'd say the patch is x86 specific. Than it should have, say, "x86:" as a prefix and it should be sent to the people and lists taking care of x86. But a quick grep suggests it's not OK to disable this for all other architectures. Did I miss something with that quick grep? Thanks, Paul Bolle