From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuXcn-00038D-87 for qemu-devel@nongnu.org; Mon, 18 May 2015 22:51:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuXcm-0001SC-9i for qemu-devel@nongnu.org; Mon, 18 May 2015 22:51:21 -0400 From: Fam Zheng Date: Tue, 19 May 2015 10:50:57 +0000 Message-Id: <1432032670-15124-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Juan Quintela , Jason Wang , Vincenzo Maffione , "Vassili Karpov (malc)" , Gerd Hoffmann , Stefan Hajnoczi , Amit Shah , Paolo Bonzini , Giuseppe Lettieri , Luigi Rizzo v3: Replace previous 13 with a simple return type conversion patch. Drop RFC. This carries out the mandate in the comment of qemu_set_fd_handler2 and removes fd_read_poll from the code base, because it will make the work easier to convert ppoll to epoll in main loop. Also, the aio interface doesn't have a read poll callback, which means this conversion woule be necessary if we want to move iohandler fds from main loop to AioContext. There are five users of the read poll callback now: qemu-nbd, l2tpv3, netmap, socket and tap, which are all covered. Patch 1 adds a stub for qemu_set_fd_handler which will be referenced in coming patches. Patch 2 converts qemu-nbd which compares two global numbers in the fd_read_poll callback. Patches 3~6 converts the four net devices, all of which checks qemu_can_send_packet() in the callback. Patch 7 and 8 finally removes the function. The rest patches are cleanup for the unuseful return value of qemu_set_fd_handler. Please review! Fam Zheng (13): stubs: Add qemu_set_fd_handler qemu-nbd: Switch to qemu_set_fd_handler l2tpv3: Drop l2tpv3_can_send netmap: Drop netmap_can_send net/socket: Drop net_socket_can_send tap: Drop tap_can_send Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler main-loop: Drop qemu_set_fd_handler2 alsaaudio: Remove unused error handling of qemu_set_fd_handler oss: Remove unused error handling of qemu_set_fd_handler xen_backend: Remove unused error handling of qemu_set_fd_handler event-notifier: Always return 0 for posix implementation iohandler: Change return type of qemu_set_fd_handler to "void" audio/alsaaudio.c | 16 ++----------- audio/ossaudio.c | 14 ++++++----- blockdev-nbd.c | 4 ++-- hw/xen/xen_backend.c | 4 +--- include/block/aio.h | 2 +- include/qemu/main-loop.h | 57 ++++----------------------------------------- iohandler.c | 21 ++--------------- main-loop.c | 3 +-- migration/exec.c | 6 ++--- migration/fd.c | 4 ++-- migration/rdma.c | 7 +++--- migration/tcp.c | 6 ++--- migration/unix.c | 6 ++--- net/l2tpv3.c | 17 ++++---------- net/netmap.c | 20 ++++------------ net/socket.c | 37 +++++++++++++++++------------ net/tap.c | 28 +++++++++++----------- qemu-nbd.c | 21 +++++++++++++---- stubs/set-fd-handler.c | 3 +-- ui/vnc-auth-sasl.c | 2 +- ui/vnc-auth-vencrypt.c | 2 +- ui/vnc-ws.c | 6 ++--- ui/vnc.c | 27 ++++++++++----------- util/event_notifier-posix.c | 3 ++- util/qemu-sockets.c | 8 +++---- 25 files changed, 120 insertions(+), 204 deletions(-) -- 2.4.1