All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>,
	xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2] tools: add configure --with-dumpdir=DIR option
Date: Thu, 21 May 2015 16:23:28 +0100	[thread overview]
Message-ID: <1432221808.10746.84.camel@citrix.com> (raw)
In-Reply-To: <20150521142755.GA32716@aepfle.de>

On Thu, 2015-05-21 at 16:27 +0200, Olaf Hering wrote:
> On Thu, May 21, Ian Campbell wrote:
> 
> > On Mon, 2015-05-11 at 15:33 +0000, Olaf Hering wrote:
> > [...]
> > > +AC_ARG_WITH([xen-dumpdir],
> > > +    AS_HELP_STRING([--with-xen-dumpdir=DIR],
> > > +    [Path to directory for domU crash dumps. [/var/lib/xen/dump]]),
> > 
> > Should this say $localstatedir/lib/xen/dump as below?
> 
> This is the help output, the line below is a variable assignment.
> I think its ok as it is. Perhaps /var can be replaced with LOCALSTATEDIR
> to make it clearer.

Based on the other things in configure --help I think that's right. Ive
applied making that change, thanks.

> configure --help suggests that --localestatedir is PREFIX/var, but we
> force it to be /var. Too bad that can not be changed because it comes
> from generic code, I think.

I vaguely recall coming to the same conclusion when I looked at this :-(

  reply	other threads:[~2015-05-21 15:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 15:33 [PATCH v2] tools: add configure --with-dumpdir=DIR option Olaf Hering
2015-05-21 14:09 ` Ian Campbell
2015-05-21 14:27   ` Olaf Hering
2015-05-21 15:23     ` Ian Campbell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-06  7:08 Olaf Hering
2015-05-07  8:01 ` Wei Liu
2015-05-07  8:10   ` Olaf Hering
2015-05-07  8:14     ` Wei Liu
2015-05-07  9:22     ` Ian Campbell
2015-05-08  6:54       ` Olaf Hering
2015-05-08  9:37         ` Ian Campbell
2015-05-11 14:17           ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432221808.10746.84.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=olaf@aepfle.de \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.