From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v8 05/13] x86: expose CBM length and COS
 number information
Date: Thu, 28 May 2015 16:46:21 +0100
Message-ID: <1432827981.2483.32.camel@citrix.com>
References: <1432197704-20816-1-git-send-email-chao.p.peng@linux.intel.com>
	<1432197704-20816-6-git-send-email-chao.p.peng@linux.intel.com>
	<5567338B020000780007E9AE@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6884850362246406222=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5567338B020000780007E9AE@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, Chao Peng <chao.p.peng@linux.intel.com>, dgdegra@tycho.nsa.gov, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

--===============6884850362246406222==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-hb9OoH5s+LaL7cE7ADmM"

--=-hb9OoH5s+LaL7cE7ADmM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-05-28 at 14:26 +0100, Jan Beulich wrote:
> >>> On 21.05.15 at 10:41, <chao.p.peng@linux.intel.com> wrote:

> > --- a/xen/include/public/sysctl.h
> > +++ b/xen/include/public/sysctl.h
> > @@ -694,6 +694,20 @@ struct xen_sysctl_pcitopoinfo {
> >  typedef struct xen_sysctl_pcitopoinfo xen_sysctl_pcitopoinfo_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t);
> > =20
> > +#define XEN_SYSCTL_PSR_CAT_get_l3_info               0
> > +struct xen_sysctl_psr_cat_op {
> > +    uint32_t cmd;       /* IN: XEN_SYSCTL_PSR_CAT_* */
> > +    uint32_t target;    /* IN: socket to be operated on */
>=20
> If this is always the socket number, why would the variable be
> named anything other than "socket". If otoh subsequent patches
> use it differently, I think the comment should be omitted now
> rather than being dropped then (or it should be given its final
> wording from the beginning).
>=20
ISTR asking about this interface before (it might have been at the
toolstack level, though), and the answer was that it is not subsequent
patches _in_this_series_ (of course), but maybe future ones that will
modify the 'per-socket-ness' nature of this feature.

So, yes, maybe the comment should say something along those lines (and
be updated when things change).

Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-hb9OoH5s+LaL7cE7ADmM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlVnOE0ACgkQk4XaBE3IOsQFfgCffON44O6K2GC5A0ihy5XQgTqQ
U30An3K4IgMaNuQbh72QyrkW41U7ysmx
=XE6U
-----END PGP SIGNATURE-----

--=-hb9OoH5s+LaL7cE7ADmM--


--===============6884850362246406222==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6884850362246406222==--