From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v8 05/13] x86: expose CBM length and COS
 number information
Date: Fri, 29 May 2015 10:23:13 +0100
Message-ID: <1432891393.5077.5.camel@citrix.com>
References: <1432197704-20816-1-git-send-email-chao.p.peng@linux.intel.com>
	<1432197704-20816-6-git-send-email-chao.p.peng@linux.intel.com>
	<5567338B020000780007E9AE@mail.emea.novell.com>
	<20150529024713.GD18422@pengc-linux.bj.intel.com>
	<55683A66020000780007ED50@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8696723860830025184=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55683A66020000780007ED50@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, Chao Peng <chao.p.peng@linux.intel.com>, dgdegra@tycho.nsa.gov, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

--===============8696723860830025184==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-BC/NMEG4mB7zYwRNtjhp"

--=-BC/NMEG4mB7zYwRNtjhp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-05-29 at 09:07 +0100, Jan Beulich wrote:
> >>> On 29.05.15 at 04:47, <chao.p.peng@linux.intel.com> wrote:
> > On Thu, May 28, 2015 at 02:26:03PM +0100, Jan Beulich wrote:
> >>=20
> >> > --- a/xen/include/public/sysctl.h
> >> > +++ b/xen/include/public/sysctl.h
> >> > @@ -694,6 +694,20 @@ struct xen_sysctl_pcitopoinfo {
> >> >  typedef struct xen_sysctl_pcitopoinfo xen_sysctl_pcitopoinfo_t;
> >> >  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t);
> >> > =20
> >> > +#define XEN_SYSCTL_PSR_CAT_get_l3_info               0
> >> > +struct xen_sysctl_psr_cat_op {
> >> > +    uint32_t cmd;       /* IN: XEN_SYSCTL_PSR_CAT_* */
> >> > +    uint32_t target;    /* IN: socket to be operated on */
> >>=20
> >> If this is always the socket number, why would the variable be
> >> named anything other than "socket". If otoh subsequent patches
> >> use it differently, I think the comment should be omitted now
> >> rather than being dropped then (or it should be given its final
> >> wording from the beginning).
> >=20
> > Or 'target to be operated on'?
>=20
> Fine with me. Just not something that may end up being confusing.
>=20
So, I really don't want to turn this into pure bikeshedding, but, for a
field called 'target', a comment saying 'target to be operated on' seems
rather pointless, and I'd go for omitting it (for now).

Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-BC/NMEG4mB7zYwRNtjhp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlVoMAEACgkQk4XaBE3IOsSh7ACdH93Sg41K2+Sc44fwjxvUHfjl
eHMAn2g//P5SxKUqUwrxn2MrGqyNzuiA
=quiC
-----END PGP SIGNATURE-----

--=-BC/NMEG4mB7zYwRNtjhp--


--===============8696723860830025184==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8696723860830025184==--