From: clsoto@linux.vnet.ibm.com
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, amirv@mellanox.com, jackm@mellanox.com,
brking@linux.vnet.ibm.com, clsoto@linux.vnet.ibm.com
Subject: [PATCH net] net/mlx4: need to call close fw if alloc icm is called twice
Date: Mon, 1 Jun 2015 09:41:43 -0500 [thread overview]
Message-ID: <1433169704-32307-2-git-send-email-clsoto@linux.vnet.ibm.com> (raw)
In-Reply-To: <1433169704-32307-1-git-send-email-clsoto@linux.vnet.ibm.com>
If mlx4_enable_sriov is called by adapter without this
feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this
path the function alloc icm is called twice without
freeing the structures from the first time.
Signed-off-by: Carol L Soto <clsoto@linux.vnet.ibm.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2837,6 +2837,7 @@ slave_start:
existing_vfs,
reset_flow);
+ mlx4_close_fw(dev);
mlx4_cmd_cleanup(dev, MLX4_CMD_CLEANUP_ALL);
dev->flags = dev_flags;
if (!SRIOV_VALID_STATE(dev->flags)) {
next prev parent reply other threads:[~2015-06-01 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:41 [PATCH net] net/mlx4: double free of dev_vfs clsoto
2015-06-01 14:41 ` clsoto [this message]
2015-06-02 7:25 ` [PATCH net] net/mlx4: need to call close fw if alloc icm is called twice Or Gerlitz
2015-06-01 14:41 ` [PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac clsoto
2015-06-02 7:25 ` [PATCH net] net/mlx4: double free of dev_vfs Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433169704-32307-2-git-send-email-clsoto@linux.vnet.ibm.com \
--to=clsoto@linux.vnet.ibm.com \
--cc=amirv@mellanox.com \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jackm@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.