All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gioh Kim <gioh.kim@lge.com>
To: jlayton@poochiereds.net, bfields@fieldses.org,
	akpm@linux-foundation.org, vbabka@suse.cz,
	iamjoonsoo.kim@lge.com, mst@redhat.com, kirill@shutemov.name,
	minchan@kernel.org, mgorman@suse.de
Cc: linux-mm@kvack.org, Gioh Kim <gioh.kim@lge.com>,
	gunho.lee@lge.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: [RFC 4/4] mm: remove direct calling of migration
Date: Tue,  2 Jun 2015 16:27:44 +0900	[thread overview]
Message-ID: <1433230065-3573-5-git-send-email-gioh.kim__13462.2004385621$1433230094$gmane$org@lge.com> (raw)
In-Reply-To: <1433230065-3573-1-git-send-email-gioh.kim@lge.com>

Migration is completely generalized.

Signed-off-by: Gioh Kim <gioh.kim@lge.com>
---
 mm/balloon_compaction.c |  8 --------
 mm/migrate.c            | 15 ---------------
 2 files changed, 23 deletions(-)

diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
index f98a500..d29270aa 100644
--- a/mm/balloon_compaction.c
+++ b/mm/balloon_compaction.c
@@ -206,13 +206,6 @@ int balloon_page_migrate(struct address_space *mapping,
 	if (!isolated_balloon_page(page))
 		return rc;
 
-	/*
-	 * Block others from accessing the 'newpage' when we get around to
-	 * establishing additional references. We should be the only one
-	 * holding a reference to the 'newpage' at this point.
-	 */
-	BUG_ON(!trylock_page(newpage));
-
 	if (WARN_ON(!__is_movable_balloon_page(page))) {
 		dump_page(page, "not movable balloon page");
 		unlock_page(newpage);
@@ -222,7 +215,6 @@ int balloon_page_migrate(struct address_space *mapping,
 	if (balloon && balloon->migratepage)
 		rc = balloon->migratepage(balloon, newpage, page, mode);
 
-	unlock_page(newpage);
 	return rc;
 }
 
diff --git a/mm/migrate.c b/mm/migrate.c
index 649b1cd..ca47b3e 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -844,21 +844,6 @@ static int __unmap_and_move(struct page *page, struct page *newpage,
 		}
 	}
 
-	if (unlikely(driver_page_migratable(page))) {
-		/*
-		 * A migratable-page does not need any special attention from
-		 * physical to virtual reverse mapping procedures.
-		 * Skip any attempt to unmap PTEs or to remap swap cache,
-		 * in order to avoid burning cycles at rmap level, and perform
-		 * the page migration right away (proteced by page lock).
-		 */
-		rc = page->mapping->a_ops->migratepage(page->mapping,
-						       newpage,
-						       page,
-						       mode);
-		goto out_unlock;
-	}
-
 	/*
 	 * Corner case handling:
 	 * 1. When a new swap-cache page is read into, it is added to the LRU
-- 
1.9.1

  parent reply	other threads:[~2015-06-02  7:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02  7:27 [RFC 0/4] enable migration of non-LRU pages Gioh Kim
2015-06-02  7:27 ` Gioh Kim
2015-06-02  7:27 ` Gioh Kim
2015-06-02  7:27 ` [RFC 1/4] mm/compaction: enable driver page migration Gioh Kim
2015-06-02  7:27   ` Gioh Kim
2015-06-02  7:27 ` Gioh Kim
2015-06-02  7:27 ` [RFC 2/4] mm/balloon: apply driver page migratable into balloon driver Gioh Kim
2015-06-02  7:27   ` Gioh Kim
2015-06-03  1:49   ` Konstantin Khlebnikov
2015-06-03  1:49     ` Konstantin Khlebnikov
2015-06-03  4:54     ` Gioh Kim
2015-06-03  4:54       ` Gioh Kim
2015-06-03  4:54     ` Gioh Kim
2015-06-03  1:49   ` Konstantin Khlebnikov
2015-06-02  7:27 ` Gioh Kim
2015-06-02  7:27 ` [RFC 3/4] mm/compaction: compaction calls generic migration Gioh Kim
2015-06-02  7:27 ` Gioh Kim
2015-06-02  7:27   ` Gioh Kim
2015-06-02  7:27 ` Gioh Kim [this message]
2015-06-02  7:27 ` [RFC 4/4] mm: remove direct calling of migration Gioh Kim
2015-06-02  7:27   ` Gioh Kim
2015-06-05 13:53 ` [RFC 0/4] enable migration of non-LRU pages Rafael Aquini
2015-06-05 13:53   ` Rafael Aquini
2015-06-05 14:35   ` Gioh Kim
2015-06-05 14:35   ` Gioh Kim
2015-06-05 14:35     ` Gioh Kim
2015-06-05 14:43     ` Rafael Aquini
2015-06-05 14:43     ` Rafael Aquini
2015-06-05 14:43       ` Rafael Aquini
2015-06-05 13:53 ` Rafael Aquini
2015-06-10  0:08 ` Minchan Kim
2015-06-10  0:08   ` Minchan Kim
2015-06-10  0:08   ` Minchan Kim
2015-06-10  1:08   ` Gioh Kim
2015-06-10  1:08     ` Gioh Kim
2015-06-10  1:08     ` Gioh Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1433230065-3573-5-git-send-email-gioh.kim__13462.2004385621$1433230094$gmane$org@lge.com' \
    --to=gioh.kim@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=gunho.lee@lge.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jlayton@poochiereds.net \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=mst@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.