From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzglN-0000Fg-Da for qemu-devel@nongnu.org; Tue, 02 Jun 2015 03:37:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzglK-0007Uf-7q for qemu-devel@nongnu.org; Tue, 02 Jun 2015 03:37:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzglK-0007Tb-1x for qemu-devel@nongnu.org; Tue, 02 Jun 2015 03:37:26 -0400 Message-ID: <1433230633.1637.16.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 02 Jun 2015 09:37:13 +0200 In-Reply-To: <556C535B.60307@redhat.com> References: <20150531181048.GC5268@redhat.com> <556C046B.9070704@redhat.com> <20150601092645-mutt-send-email-mst@redhat.com> <556C1F63.1090605@redhat.com> <20150601121908-mutt-send-email-mst@redhat.com> <556C3757.7080603@redhat.com> <20150601124604-mutt-send-email-mst@redhat.com> <556C417D.4050707@redhat.com> <20150601143447-mutt-send-email-mst@redhat.com> <556C5275.7010702@redhat.com> <20150601144015-mutt-send-email-mst@redhat.com> <556C535B.60307@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: matt.fleming@intel.com, "Michael S. Tsirkin" , "Gabriel L. Somlo" , qemu-devel@nongnu.org, gsomlo@gmail.com, Laszlo Ersek On Mo, 2015-06-01 at 14:43 +0200, Paolo Bonzini wrote: > > On 01/06/2015 14:41, Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 01/06/2015 14:38, Michael S. Tsirkin wrote: > >>> I'm sorry - I don't understand. It's easy to do the right thing. Just > >>> add the opt prefix. Why insist on user doing the right thing, and punish > >>> violations with failing at random? > >>> > >>> If it's useful for developers somehow, add a config flag for that. > >> > >> You've already been explained that config flags are not an answer. > > > > Oh then just #define FW_CFG_USER_PREFIX "opt/". > > > > Developers can edit that to "" if they want to play. > > Shall we agree to just let Gerd decide since he's handling these patches? I can't see a strong reasons to change things. The docs clearly recommend to use opt/ prefix to avoid conflicts. That is fine IMHO. I don't feel like enforcing that in code, being able to use something else can be useful for debugging/testing purposes. For example there are some etc/* things seabios looks at which qemu has no support for. One can also supply option roms with the new switch. cheers, Gerd