From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932294AbbFBIOp (ORCPT ); Tue, 2 Jun 2015 04:14:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47661 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755660AbbFBINt (ORCPT ); Tue, 2 Jun 2015 04:13:49 -0400 Message-ID: <1433232775.1708.11.camel@suse.com> Subject: Re: [PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers From: Oliver Neukum To: Alexey Sokolov Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 02 Jun 2015 10:12:55 +0200 In-Reply-To: <20150602080526.GC6379@user-VirtualBox> References: <20150602080526.GC6379@user-VirtualBox> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-06-02 at 11:05 +0300, Alexey Sokolov wrote: > ATOL FPrint fiscal printers require usb_clear_halt to be executed > to work properly. Add quirk to fix the issue. > Hi, thank you for this patch. > Signed-off-by: Alexey Sokolov > --- > drivers/usb/class/cdc-acm.c | 9 +++++++++ > drivers/usb/class/cdc-acm.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index 5c8f581..9d8a321 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -1477,6 +1477,11 @@ skip_countries: > goto alloc_fail8; > } > > + if (quirks == CLEAR_HALT_CONDITIONS) { Please make that quirks & CLEAR_HALT_CONDITIONS Regards Oliver