From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 06/21] drm/i915/gtt: Remove _single from page table allocator Date: Tue, 02 Jun 2015 12:53:42 +0300 Message-ID: <1433238822.23912.0.camel@jlahtine-mobl1> References: <1432314314-23530-1-git-send-email-mika.kuoppala@intel.com> <1432314314-23530-7-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 42BB76E7E4 for ; Tue, 2 Jun 2015 02:53:45 -0700 (PDT) In-Reply-To: <1432314314-23530-7-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTUtMDUtMjIgYXQgMjA6MDQgKzAzMDAsIE1pa2EgS3VvcHBhbGEgd3JvdGU6Cj4g V2UgYXJlIGFsd2F5cyBhbGxvY2F0aW5nIGEgc2luZ2xlIHBhZ2UuIE5vIG5lZWQgdG8gYmUgdmVy Ym9zZSBzbwo+IHJlbW92ZSB0aGUgc3VmZml4Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3Vv cHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgpSZXZpZXdlZC1ieTogSm9vbmFzIExhaHRp bmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyB8IDE2ICsrKysrKysrLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9ndHQuYwo+IGluZGV4IGE2MDhiMWIuLjRjZjQ3ZjkgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBAIC0zNjksNyArMzY5LDcgQEAgc3RhdGljIHZv aWQgZ2VuOF9pbml0aWFsaXplX3B0KHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAJ a3VubWFwX2F0b21pYyhwdF92YWRkcik7Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgaTkxNV9w YWdlX3RhYmxlICphbGxvY19wdF9zaW5nbGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiArc3Rh dGljIHN0cnVjdCBpOTE1X3BhZ2VfdGFibGUgKmFsbG9jX3B0KHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gIHsKPiAgCXN0cnVjdCBpOTE1X3BhZ2VfdGFibGUgKnB0Owo+ICAJY29uc3Qgc2l6ZV90 IGNvdW50ID0gSU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gOCA/Cj4gQEAgLTQxNyw3ICs0MTcsNyBA QCBzdGF0aWMgdm9pZCB1bm1hcF9hbmRfZnJlZV9wZChzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9y eSAqcGQsCj4gIAl9Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9y eSAqYWxsb2NfcGRfc2luZ2xlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gK3N0YXRpYyBzdHJ1 Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeSAqYWxsb2NfcGQoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiAgewo+ICAJc3RydWN0IGk5MTVfcGFnZV9kaXJlY3RvcnkgKnBkOwo+ICAJaW50IHJldCA9IC1F Tk9NRU07Cj4gQEAgLTcwMiw3ICs3MDIsNyBAQCBzdGF0aWMgaW50IGdlbjhfcHBndHRfYWxsb2Nf cGFnZXRhYnMoc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0LAo+ICAJCQljb250aW51ZTsKPiAg CQl9Cj4gIAo+IC0JCXB0ID0gYWxsb2NfcHRfc2luZ2xlKGRldik7Cj4gKwkJcHQgPSBhbGxvY19w dChkZXYpOwo+ICAJCWlmIChJU19FUlIocHQpKQo+ICAJCQlnb3RvIHVud2luZF9vdXQ7Cj4gIAo+ IEBAIC03NjAsNyArNzYwLDcgQEAgc3RhdGljIGludCBnZW44X3BwZ3R0X2FsbG9jX3BhZ2VfZGly ZWN0b3JpZXMoc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0LAo+ICAJCWlmIChwZCkKPiAgCQkJ Y29udGludWU7Cj4gIAo+IC0JCXBkID0gYWxsb2NfcGRfc2luZ2xlKGRldik7Cj4gKwkJcGQgPSBh bGxvY19wZChkZXYpOwo+ICAJCWlmIChJU19FUlIocGQpKQo+ICAJCQlnb3RvIHVud2luZF9vdXQ7 Cj4gIAo+IEBAIC05OTIsMTEgKzk5MiwxMSBAQCBzdGF0aWMgaW50IGdlbjhfcHJlYWxsb2NhdGVf dG9wX2xldmVsX3BkcHMoc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0KQo+ICAgKi8KPiAgc3Rh dGljIGludCBnZW44X3BwZ3R0X2luaXQoc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0KQo+ICB7 Cj4gLQlwcGd0dC0+c2NyYXRjaF9wdCA9IGFsbG9jX3B0X3NpbmdsZShwcGd0dC0+YmFzZS5kZXYp Owo+ICsJcHBndHQtPnNjcmF0Y2hfcHQgPSBhbGxvY19wdChwcGd0dC0+YmFzZS5kZXYpOwo+ICAJ aWYgKElTX0VSUihwcGd0dC0+c2NyYXRjaF9wdCkpCj4gIAkJcmV0dXJuIFBUUl9FUlIocHBndHQt PnNjcmF0Y2hfcHQpOwo+ICAKPiAtCXBwZ3R0LT5zY3JhdGNoX3BkID0gYWxsb2NfcGRfc2luZ2xl KHBwZ3R0LT5iYXNlLmRldik7Cj4gKwlwcGd0dC0+c2NyYXRjaF9wZCA9IGFsbG9jX3BkKHBwZ3R0 LT5iYXNlLmRldik7Cj4gIAlpZiAoSVNfRVJSKHBwZ3R0LT5zY3JhdGNoX3BkKSkKPiAgCQlyZXR1 cm4gUFRSX0VSUihwcGd0dC0+c2NyYXRjaF9wZCk7Cj4gIAo+IEBAIC0xMzc1LDcgKzEzNzUsNyBA QCBzdGF0aWMgaW50IGdlbjZfYWxsb2NfdmFfcmFuZ2Uoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFj ZSAqdm0sCj4gIAkJLyogV2UndmUgYWxyZWFkeSBhbGxvY2F0ZWQgYSBwYWdlIHRhYmxlICovCj4g IAkJV0FSTl9PTighYml0bWFwX2VtcHR5KHB0LT51c2VkX3B0ZXMsIEdFTjZfUFRFUykpOwo+ICAK PiAtCQlwdCA9IGFsbG9jX3B0X3NpbmdsZShkZXYpOwo+ICsJCXB0ID0gYWxsb2NfcHQoZGV2KTsK PiAgCQlpZiAoSVNfRVJSKHB0KSkgewo+ICAJCQlyZXQgPSBQVFJfRVJSKHB0KTsKPiAgCQkJZ290 byB1bndpbmRfb3V0Owo+IEBAIC0xNDYxLDcgKzE0NjEsNyBAQCBzdGF0aWMgaW50IGdlbjZfcHBn dHRfYWxsb2NhdGVfcGFnZV9kaXJlY3RvcmllcyhzdHJ1Y3QgaTkxNV9od19wcGd0dCAqcHBndHQp Cj4gIAkgKiBzaXplLiBXZSBhbGxvY2F0ZSBhdCB0aGUgdG9wIG9mIHRoZSBHVFQgdG8gYXZvaWQg ZnJhZ21lbnRhdGlvbi4KPiAgCSAqLwo+ICAJQlVHX09OKCFkcm1fbW1faW5pdGlhbGl6ZWQoJmRl dl9wcml2LT5ndHQuYmFzZS5tbSkpOwo+IC0JcHBndHQtPnNjcmF0Y2hfcHQgPSBhbGxvY19wdF9z aW5nbGUocHBndHQtPmJhc2UuZGV2KTsKPiArCXBwZ3R0LT5zY3JhdGNoX3B0ID0gYWxsb2NfcHQo cHBndHQtPmJhc2UuZGV2KTsKPiAgCWlmIChJU19FUlIocHBndHQtPnNjcmF0Y2hfcHQpKQo+ICAJ CXJldHVybiBQVFJfRVJSKHBwZ3R0LT5zY3JhdGNoX3B0KTsKPiAgCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK