From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030186AbbFELDj (ORCPT ); Fri, 5 Jun 2015 07:03:39 -0400 Received: from casper.infradead.org ([85.118.1.10]:52380 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932540AbbFELDb convert rfc822-to-8bit (ORCPT ); Fri, 5 Jun 2015 07:03:31 -0400 Message-ID: <1433502202.1495.10.camel@twins> Subject: Re: [PATCH 14/14] sched,lockdep: Employ lock pinning From: Peter Zijlstra To: Ingo Molnar Cc: umgwanakikbuti@gmail.com, mingo@elte.hu, ktkhai@parallels.com, rostedt@goodmis.org, tglx@linutronix.de, juri.lelli@gmail.com, pang.xunlei@linaro.org, oleg@redhat.com, wanpeng.li@linux.intel.com, linux-kernel@vger.kernel.org Date: Fri, 05 Jun 2015 13:03:22 +0200 In-Reply-To: <20150605095738.GB7893@gmail.com> References: <20150605084836.364306429@infradead.org> <20150605085206.235165696@infradead.org> <20150605095738.GB7893@gmail.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-06-05 at 11:57 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > Employ the new lockdep lock pinning annotation to ensure no > > 'accidental' lock-breaks happen with rq->lock. > > btw., could we perhaps reorder this series a bit and first see that it properly > detects the original locking bug, and then only fix the bug? > > To make sure the pinning infrastructure works and all that. It works; I've had plenty explosions while trying to get some of the less obvious code paths sorted. I've managed to hit every single WARN I added ;-) Also, for bisection it might be annoying to hit known bad points, which is why its ordered this way.