All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
To: Matt Fleming <matt.fleming@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	fu.wei@linaro.org, al.stone@linaro.org, bp@alien8.de,
	tony.luck@gmail.com, rjw@rjwysocki.net, lenb@kernel.org,
	ying.huang@intel.com
Cc: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory
Date: Thu, 11 Jun 2015 11:26:00 -0700	[thread overview]
Message-ID: <1434047160-23358-5-git-send-email-zjzhang@codeaurora.org> (raw)
In-Reply-To: <1434047160-23358-1-git-send-email-zjzhang@codeaurora.org>

From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>

With ACPI APEI firmware first handling, generic hardware error
record is updated by firmware in GHES memory region. When firmware
updated GHES memory region with uncached access attribute, Linux
reads stale data from cache.

GHES memory region should be mapped with cache attributes
according to EFI memory map when applicable. On such system, if
firmware updates RAM directly without going through cache,
EFI memory map has GHES memory region defined as uncached;
If firmware updates cache, EFI memory map has GHES memory region
defined as cached.

On EFI system, if GHES memory region has EFI_MEMORY_UC attribute
defined, map the page with arch defined UC page protection type.

Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
---
 drivers/acpi/apei/ghes.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index e82d0976a5d0..5cfd951ebf67 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -48,6 +48,7 @@
 #include <linux/pci.h>
 #include <linux/aer.h>
 #include <linux/nmi.h>
+#include <linux/efi.h>
 
 #include <acpi/ghes.h>
 #include <acpi/apei.h>
@@ -164,8 +165,14 @@ static void __iomem *ghes_ioremap_pfn_irq(u64 pfn)
 	unsigned long vaddr;
 
 	vaddr = (unsigned long)GHES_IOREMAP_IRQ_PAGE(ghes_ioremap_area->addr);
-	ioremap_page_range(vaddr, vaddr + PAGE_SIZE,
+
+	if (efi_mem_attributes(pfn << PAGE_SHIFT) & EFI_MEMORY_UC) {
+		ioremap_page_range(vaddr, vaddr + PAGE_SIZE,
+				   pfn << PAGE_SHIFT, ARCH_APEI_PAGE_KERNEL_UC);
+	} else {
+		ioremap_page_range(vaddr, vaddr + PAGE_SIZE,
 			   pfn << PAGE_SHIFT, PAGE_KERNEL);
+	}
 
 	return (void __iomem *)vaddr;
 }
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-06-11 18:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 18:25 [PATCH V3 0/4] map GHES memory region with EFI memory map Jonathan (Zhixiong) Zhang
2015-06-11 18:25 ` [PATCH V3 1/4] x86: acpi: define uncached page flag Jonathan (Zhixiong) Zhang
2015-06-12  7:52   ` Ingo Molnar
2015-06-12 23:49     ` Zhang, Jonathan Zhixiong
2015-06-11 18:25 ` [PATCH V3 2/4] arm64: " Jonathan (Zhixiong) Zhang
2015-06-11 18:25 ` [PATCH V3 3/4] efi: x86: rearrange efi_mem_attributes() Jonathan (Zhixiong) Zhang
2015-06-11 18:26 ` Jonathan (Zhixiong) Zhang [this message]
2015-06-12 16:29   ` [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory Borislav Petkov
2015-06-12 23:44     ` Zhang, Jonathan Zhixiong
2015-06-13  8:27       ` Borislav Petkov
2015-06-15 14:15         ` Matt Fleming
2015-06-15 14:59           ` Borislav Petkov
2015-06-22  5:11             ` Matt Fleming
2015-06-22  5:11               ` Matt Fleming
2015-06-23  9:50               ` Matt Fleming
     [not found] <E1ZG8Pn-0002uB-2C@feisty.vs19.net>
2015-07-21  0:22 ` Zhang, Jonathan Zhixiong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434047160-23358-5-git-send-email-zjzhang@codeaurora.org \
    --to=zjzhang@codeaurora.org \
    --cc=al.stone@linaro.org \
    --cc=bp@alien8.de \
    --cc=fu.wei@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@gmail.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.