From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id F3D7FE0098F; Fri, 12 Jun 2015 13:12:07 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [134.134.136.24 listed in list.dnswl.org] Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 77E9BE0086D for ; Fri, 12 Jun 2015 13:12:00 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 12 Jun 2015 13:12:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,604,1427785200"; d="scan'208";a="586884927" Received: from yctb03.ostc.intel.com (HELO yctb03.otcr.jf.intel.com) ([10.23.219.52]) by orsmga003.jf.intel.com with ESMTP; 12 Jun 2015 13:11:58 -0700 From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= To: yocto@yoctoproject.org Date: Fri, 12 Jun 2015 20:10:45 +0000 Message-Id: <1434139845-34607-1-git-send-email-anibal.limon@linux.intel.com> X-Mailer: git-send-email 1.8.4.5 MIME-Version: 1.0 Cc: paul.eggleton@linux.intel.com Subject: [PATCHv2 09/11][auh] upgradehelper.py: Change policy for send emails and fix error passing X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 20:12:08 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Now send emails almost in all cases this give the maintainer patches and diff to continue work also if the build isn't succesful. [YOCTO #7489] Signed-off-by: Aníbal Limón --- upgradehelper.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/upgradehelper.py b/upgradehelper.py index b1f075d..d065fba 100755 --- a/upgradehelper.py +++ b/upgradehelper.py @@ -346,8 +346,6 @@ class Updater(object): self.git.clean_untracked() return - status = type(err).__name__ - # drop last upgrade from git. It's safer this way if the upgrade has # problems and other recipes depend on it. Give the other recipes a # chance... @@ -381,8 +379,14 @@ class Updater(object): "Attached are the patch, license diff (if change) and bitbake log.\n\n" \ "Regards,\nThe Upgrade Helper" - # don't bother maintainer with mail if the recipe is already up to date - if status == "UpgradeNotNeededError": + # if error only send email when useful infomration for maintainers exist + if err and not (isinstance(err, PatchError) or \ + isinstance(err, ConfigureError) or \ + isinstance(err, CompilationError) or \ + isinstance(err, LicenseError)): + D( "%s: Don't send email to maintainer because the error was " \ + "%s and the information isn't useful, please review it." \ + % (self.pn, type(err).__name__)) return if self.maintainer in maintainer_override: @@ -478,6 +482,7 @@ class Updater(object): attempted_pkgs = 0 for self.pn, self.new_ver, self.maintainer in pkgs_to_upgrade: + error = None self.recipe = None attempted_pkgs += 1 I(" ATTEMPT PACKAGE %d/%d" % (attempted_pkgs, total_pkgs)) @@ -489,10 +494,6 @@ class Updater(object): step() I(" %s: Upgrade SUCCESSFUL! Please test!" % self.pn) - error = None - except UpgradeNotNeededError as e: - I(" %s: %s" % (self.pn, e.message)) - error = e except Error as e: E(" %s: %s" % (self.pn, e.message)) E(" %s: Upgrade FAILED! Logs and/or file diffs are available in %s" % (self.pn, self.workdir)) @@ -667,7 +668,7 @@ class UniverseUpdater(Updater): # overriding the base method def pkg_upgrade_handler(self, err): - super(UniverseUpdater, self).pkg_upgrade_handler(self) + super(UniverseUpdater, self).pkg_upgrade_handler(err) self.update_history(self.pn, self.new_ver, self.maintainer, self._get_status_msg(err)) -- 1.8.4.5