From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karthik Nayak Subject: [PATCH v8 06/11] for-each-ref: rename some functions and make them public Date: Sun, 14 Jun 2015 01:07:24 +0530 Message-ID: <1434224249-21476-6-git-send-email-karthik.188@gmail.com> References: <1434224249-21476-1-git-send-email-karthik.188@gmail.com> Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr, Karthik Nayak To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Jun 13 21:38:46 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z3rGP-0002JM-8Z for gcvg-git-2@plane.gmane.org; Sat, 13 Jun 2015 21:38:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbbFMTil (ORCPT ); Sat, 13 Jun 2015 15:38:41 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33108 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbbFMTii (ORCPT ); Sat, 13 Jun 2015 15:38:38 -0400 Received: by padev16 with SMTP id ev16so40877259pad.0 for ; Sat, 13 Jun 2015 12:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LOOlHRXujLA8YDakMrvmXNMOdIeiQF5IQlr9i12FGhU=; b=OokhmgvcwrjG4LH13MVVZfNgJ218vlrnaQb8cxo7Inj2ZTmIMy6wjj4UzscW9IONUx OKsP1Xd45JoOovXovBlO1Vqp/equg2d7gcR8kW8vpLYgPUp7GHl8Ctyr7LbrXDa8hcaI g3Z44pikFy7K+h2Picw/BhrqzD14LTK9JIro6XYlah1pIgWYUsFtRKPNAI+3xp3RiXgN MZuOuDjxRXe7pUndkQp2braC5pswXUNJIRX5/6JE/pByzDoegw9Ny4Rjrb6oBZ9hlnpH rm3m8GsXw90m0MBDm/zYHmhPuHOlHZG95apcFfcuyLFJ0CwJ4QIwYHju3ERynMPCGHL3 XktA== X-Received: by 10.68.233.71 with SMTP id tu7mr34195554pbc.14.1434224317857; Sat, 13 Jun 2015 12:38:37 -0700 (PDT) Received: from ashley.localdomain ([106.51.130.23]) by mx.google.com with ESMTPSA id nn6sm7388954pdb.79.2015.06.13.12.38.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 13 Jun 2015 12:38:37 -0700 (PDT) X-Mailer: git-send-email 2.4.3.435.g2403634.dirty In-Reply-To: <1434224249-21476-1-git-send-email-karthik.188@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Rename some of the functions and make them publicly available. This is a preparatory step for moving code from 'for-each-ref' to 'ref-filter' to make meaningful, targeted services available to other commands via public APIs. Functions renamed are: parse_atom() -> parse_ref_filter_atom() verify_format() -> verify_ref_format() get_value() -> get_ref_atom_value() grab_single_ref() -> ref_filter_handler() sort_refs() -> ref_array_sort() show_ref() -> show_ref_array_item() default_sort() -> ref_default_sorting() opt_parse_sort() -> parse_opt_ref_sorting() cmp_ref_sort() -> cmp_ref_sorting() Rename 'struct ref_sort' to 'struct ref_sorting' in this context. Based-on-patch-by: Jeff King Mentored-by: Christian Couder Mentored-by: Matthieu Moy Signed-off-by: Karthik Nayak --- builtin/for-each-ref.c | 64 +++++++++++++++++++++++++------------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c index bb83f7a..5700b25 100644 --- a/builtin/for-each-ref.c +++ b/builtin/for-each-ref.c @@ -113,7 +113,7 @@ static int need_color_reset_at_eol; /* * Used to parse format string and sort specifiers */ -static int parse_atom(const char *atom, const char *ep) +int parse_ref_filter_atom(const char *atom, const char *ep) { const char *sp; int i, at; @@ -190,7 +190,7 @@ static const char *find_next(const char *cp) * Make sure the format string is well formed, and parse out * the used atoms. */ -static int verify_format(const char *format) +int verify_ref_format(const char *format) { const char *cp, *sp; @@ -202,7 +202,7 @@ static int verify_format(const char *format) if (!ep) return error("malformed format string %s", sp); /* sp points at "%(" and ep points at the closing ")" */ - at = parse_atom(sp + 2, ep); + at = parse_ref_filter_atom(sp + 2, ep); cp = ep + 1; if (skip_prefix(used_atom[at], "color:", &color)) @@ -409,7 +409,7 @@ static void grab_date(const char *buf, struct atom_value *v, const char *atomnam /* * We got here because atomname ends in "date" or "date"; * it's not possible that is not ":" because - * parse_atom() wouldn't have allowed it, so we can assume that no + * parse_ref_filter_atom() wouldn't have allowed it, so we can assume that no * ":" means no format is specified, and use the default. */ formatp = strchr(atomname, ':'); @@ -849,7 +849,7 @@ static void populate_value(struct ref_array_item *ref) * Given a ref, return the value for the atom. This lazily gets value * out of the object by calling populate value. */ -static void get_value(struct ref_array_item *ref, int atom, struct atom_value **v) +static void get_ref_atom_value(struct ref_array_item *ref, int atom, struct atom_value **v) { if (!ref->value) { populate_value(ref); @@ -900,8 +900,7 @@ static struct ref_array_item *new_ref_array_item(const char *refname, * A call-back given to for_each_ref(). Filter refs and keep them for * later object processing. */ -static int grab_single_ref(const char *refname, const struct object_id *oid, - int flag, void *cb_data) +int ref_filter_handler(const char *refname, const struct object_id *oid, int flag, void *cb_data) { struct ref_filter_cbdata *ref_cbdata = cb_data; struct ref_filter *filter = &ref_cbdata->filter; @@ -947,14 +946,14 @@ void ref_array_clear(struct ref_array *array) array->nr = array->alloc = 0; } -static int cmp_ref_sort(struct ref_sort *s, struct ref_array_item *a, struct ref_array_item *b) +static int cmp_ref_sorting(struct ref_sorting *s, struct ref_array_item *a, struct ref_array_item *b) { struct atom_value *va, *vb; int cmp; cmp_type cmp_type = used_atom_type[s->atom]; - get_value(a, s->atom, &va); - get_value(b, s->atom, &vb); + get_ref_atom_value(a, s->atom, &va); + get_ref_atom_value(b, s->atom, &vb); switch (cmp_type) { case FIELD_STR: cmp = strcmp(va->s, vb->s); @@ -971,24 +970,24 @@ static int cmp_ref_sort(struct ref_sort *s, struct ref_array_item *a, struct ref return (s->reverse) ? -cmp : cmp; } -static struct ref_sort *ref_sort; +static struct ref_sorting *ref_sorting; static int compare_refs(const void *a_, const void *b_) { struct ref_array_item *a = *((struct ref_array_item **)a_); struct ref_array_item *b = *((struct ref_array_item **)b_); - struct ref_sort *s; + struct ref_sorting *s; - for (s = ref_sort; s; s = s->next) { - int cmp = cmp_ref_sort(s, a, b); + for (s = ref_sorting; s; s = s->next) { + int cmp = cmp_ref_sorting(s, a, b); if (cmp) return cmp; } return 0; } -static void sort_refs(struct ref_sort *sort, struct ref_array *array) +void ref_array_sort(struct ref_sorting *sort, struct ref_array *array) { - ref_sort = sort; + ref_sorting = sort; qsort(array->items, array->nr, sizeof(struct ref_array_item *), compare_refs); } @@ -1056,7 +1055,7 @@ static void emit(const char *cp, const char *ep) } } -static void show_ref(struct ref_array_item *info, const char *format, int quote_style) +void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style) { const char *cp, *sp, *ep; @@ -1066,7 +1065,7 @@ static void show_ref(struct ref_array_item *info, const char *format, int quote_ ep = strchr(sp, ')'); if (cp < sp) emit(cp, sp); - get_value(info, parse_atom(sp + 2, ep), &atomv); + get_ref_atom_value(info, parse_ref_filter_atom(sp + 2, ep), &atomv); print_value(atomv, quote_style); } if (*cp) { @@ -1085,21 +1084,22 @@ static void show_ref(struct ref_array_item *info, const char *format, int quote_ putchar('\n'); } -static struct ref_sort *default_sort(void) +/* If no sorting option is given, use refname to sort as default */ +struct ref_sorting *ref_default_sorting(void) { static const char cstr_name[] = "refname"; - struct ref_sort *sort = xcalloc(1, sizeof(*sort)); + struct ref_sorting *sort = xcalloc(1, sizeof(*sort)); sort->next = NULL; - sort->atom = parse_atom(cstr_name, cstr_name + strlen(cstr_name)); + sort->atom = parse_ref_filter_atom(cstr_name, cstr_name + strlen(cstr_name)); return sort; } -static int opt_parse_sort(const struct option *opt, const char *arg, int unset) +int parse_opt_ref_sorting(const struct option *opt, const char *arg, int unset) { - struct ref_sort **sort_tail = opt->value; - struct ref_sort *s; + struct ref_sorting **sort_tail = opt->value; + struct ref_sorting *s; int len; if (!arg) /* should --no-sort void the list ? */ @@ -1114,7 +1114,7 @@ static int opt_parse_sort(const struct option *opt, const char *arg, int unset) arg++; } len = strlen(arg); - s->atom = parse_atom(arg, arg+len); + s->atom = parse_ref_filter_atom(arg, arg+len); return 0; } @@ -1127,7 +1127,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) { int i; const char *format = "%(objectname) %(objecttype)\t%(refname)"; - struct ref_sort *sort = NULL, **sort_tail = &sort; + struct ref_sorting *sort = NULL, **sort_tail = &sort; int maxcount = 0, quote_style = 0; struct ref_filter_cbdata ref_cbdata; @@ -1145,7 +1145,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) OPT_INTEGER( 0 , "count", &maxcount, N_("show only matched refs")), OPT_STRING( 0 , "format", &format, N_("format"), N_("format to use for the output")), OPT_CALLBACK(0 , "sort", sort_tail, N_("key"), - N_("field name to sort on"), &opt_parse_sort), + N_("field name to sort on"), &parse_opt_ref_sorting), OPT_END(), }; @@ -1158,25 +1158,25 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix) error("more than one quoting style?"); usage_with_options(for_each_ref_usage, opts); } - if (verify_format(format)) + if (verify_ref_format(format)) usage_with_options(for_each_ref_usage, opts); if (!sort) - sort = default_sort(); + sort = ref_default_sorting(); /* for warn_ambiguous_refs */ git_config(git_default_config, NULL); memset(&ref_cbdata, 0, sizeof(ref_cbdata)); ref_cbdata.filter.name_patterns = argv; - for_each_rawref(grab_single_ref, &ref_cbdata); + for_each_rawref(ref_filter_handler, &ref_cbdata); - sort_refs(sort, &ref_cbdata.array); + ref_array_sort(sort, &ref_cbdata.array); if (!maxcount || ref_cbdata.array.nr < maxcount) maxcount = ref_cbdata.array.nr; for (i = 0; i < maxcount; i++) - show_ref(ref_cbdata.array.items[i], format, quote_style); + show_ref_array_item(ref_cbdata.array.items[i], format, quote_style); ref_array_clear(&ref_cbdata.array); return 0; } -- 2.4.3.435.g2403634.dirty