All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type
@ 2015-06-15 10:16 Nikhil Badola
  2015-06-26 17:12 ` Badola Nikhil
  0 siblings, 1 reply; 4+ messages in thread
From: Nikhil Badola @ 2015-06-15 10:16 UTC (permalink / raw)
  To: linux-usb, linux-kernel; +Cc: gregkh, stern, Nikhil Badola

Replace macros with enumerated type to represent usb ip
controller version

Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
---
Changes for v2 :
	- Assigned value to each enumerator
	- Changed return type of function that returns
	  controller version
	- Introduced FSL_USB_VER_NONE for invalid controller version

 drivers/usb/host/fsl-mph-dr-of.c |  8 ++++----
 include/linux/fsl_devices.h      | 16 ++++++++++------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 5e0d600..2195956 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -119,9 +119,9 @@ error:
 
 static const struct of_device_id fsl_usb2_mph_dr_of_match[];
 
-static int usb_get_ver_info(struct device_node *np)
+static enum fsl_usb2_controller_ver usb_get_ver_info(struct device_node *np)
 {
-	int ver = -1;
+	enum fsl_usb2_controller_ver ver = FSL_USB_VER_NONE;
 
 	/*
 	 * returns 1 for usb controller version 1.6
@@ -142,7 +142,7 @@ static int usb_get_ver_info(struct device_node *np)
 		else /* for previous controller versions */
 			ver = FSL_USB_VER_OLD;
 
-		if (ver > -1)
+		if (ver > FSL_USB_VER_NONE)
 			return ver;
 	}
 
@@ -215,7 +215,7 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
 	pdata->controller_ver = usb_get_ver_info(np);
 
 	if (pdata->have_sysif_regs) {
-		if (pdata->controller_ver < 0) {
+		if (pdata->controller_ver == FSL_USB_VER_NONE) {
 			dev_warn(&ofdev->dev, "Could not get controller version\n");
 			return -ENODEV;
 		}
diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
index 2a2f56b..0d4855cd 100644
--- a/include/linux/fsl_devices.h
+++ b/include/linux/fsl_devices.h
@@ -20,11 +20,6 @@
 #define FSL_UTMI_PHY_DLY	10	/*As per P1010RM, delay for UTMI
 				PHY CLK to become stable - 10ms*/
 #define FSL_USB_PHY_CLK_TIMEOUT	10000	/* uSec */
-#define FSL_USB_VER_OLD		0
-#define FSL_USB_VER_1_6		1
-#define FSL_USB_VER_2_2		2
-#define FSL_USB_VER_2_4		3
-#define FSL_USB_VER_2_5		4
 
 #include <linux/types.h>
 
@@ -52,6 +47,15 @@
  *
  */
 
+enum fsl_usb2_controller_ver {
+	FSL_USB_VER_NONE = -1,
+	FSL_USB_VER_OLD = 0,
+	FSL_USB_VER_1_6 = 1,
+	FSL_USB_VER_2_2 = 2,
+	FSL_USB_VER_2_4 = 3,
+	FSL_USB_VER_2_5 = 4,
+};
+
 enum fsl_usb2_operating_modes {
 	FSL_USB2_MPH_HOST,
 	FSL_USB2_DR_HOST,
@@ -72,7 +76,7 @@ struct platform_device;
 
 struct fsl_usb2_platform_data {
 	/* board specific information */
-	int				controller_ver;
+	enum fsl_usb2_controller_ver	controller_ver;
 	enum fsl_usb2_operating_modes	operating_mode;
 	enum fsl_usb2_phy_modes		phy_mode;
 	unsigned int			port_enables;
-- 
1.7.11.7



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type
  2015-06-15 10:16 [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type Nikhil Badola
@ 2015-06-26 17:12 ` Badola Nikhil
  2015-06-26 17:40   ` gregkh
  2015-06-26 18:17   ` Alan Stern
  0 siblings, 2 replies; 4+ messages in thread
From: Badola Nikhil @ 2015-06-26 17:12 UTC (permalink / raw)
  To: gregkh, stern; +Cc: linux-usb, linux-kernel

> -----Original Message-----
> From: Nikhil Badola [mailto:nikhil.badola@freescale.com]
> Sent: Monday, June 15, 2015 3:47 PM
> To: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: gregkh@linuxfoundation.org; stern@rowland.harvard.edu; Badola Nikhil-
> B46172
> Subject: [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated
> type
> 
> Replace macros with enumerated type to represent usb ip controller version
> 
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Changes for v2 :
> 	- Assigned value to each enumerator
> 	- Changed return type of function that returns
> 	  controller version
> 	- Introduced FSL_USB_VER_NONE for invalid controller version
> 
>  drivers/usb/host/fsl-mph-dr-of.c |  8 ++++----
>  include/linux/fsl_devices.h      | 16 ++++++++++------
>  2 files changed, 14 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-
> of.c
> index 5e0d600..2195956 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -119,9 +119,9 @@ error:
> 
>  static const struct of_device_id fsl_usb2_mph_dr_of_match[];
> 
> -static int usb_get_ver_info(struct device_node *np)
> +static enum fsl_usb2_controller_ver usb_get_ver_info(struct device_node
> +*np)
>  {
> -	int ver = -1;
> +	enum fsl_usb2_controller_ver ver = FSL_USB_VER_NONE;
> 
>  	/*
>  	 * returns 1 for usb controller version 1.6 @@ -142,7 +142,7 @@ static
> int usb_get_ver_info(struct device_node *np)
>  		else /* for previous controller versions */
>  			ver = FSL_USB_VER_OLD;
> 
> -		if (ver > -1)
> +		if (ver > FSL_USB_VER_NONE)
>  			return ver;
>  	}
> 
> @@ -215,7 +215,7 @@ static int fsl_usb2_mph_dr_of_probe(struct
> platform_device *ofdev)
>  	pdata->controller_ver = usb_get_ver_info(np);
> 
>  	if (pdata->have_sysif_regs) {
> -		if (pdata->controller_ver < 0) {
> +		if (pdata->controller_ver == FSL_USB_VER_NONE) {
>  			dev_warn(&ofdev->dev, "Could not get controller
> version\n");
>  			return -ENODEV;
>  		}
> diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h index
> 2a2f56b..0d4855cd 100644
> --- a/include/linux/fsl_devices.h
> +++ b/include/linux/fsl_devices.h
> @@ -20,11 +20,6 @@
>  #define FSL_UTMI_PHY_DLY	10	/*As per P1010RM, delay for UTMI
>  				PHY CLK to become stable - 10ms*/
>  #define FSL_USB_PHY_CLK_TIMEOUT	10000	/* uSec */
> -#define FSL_USB_VER_OLD		0
> -#define FSL_USB_VER_1_6		1
> -#define FSL_USB_VER_2_2		2
> -#define FSL_USB_VER_2_4		3
> -#define FSL_USB_VER_2_5		4
> 
>  #include <linux/types.h>
> 
> @@ -52,6 +47,15 @@
>   *
>   */
> 
> +enum fsl_usb2_controller_ver {
> +	FSL_USB_VER_NONE = -1,
> +	FSL_USB_VER_OLD = 0,
> +	FSL_USB_VER_1_6 = 1,
> +	FSL_USB_VER_2_2 = 2,
> +	FSL_USB_VER_2_4 = 3,
> +	FSL_USB_VER_2_5 = 4,
> +};
> +
>  enum fsl_usb2_operating_modes {
>  	FSL_USB2_MPH_HOST,
>  	FSL_USB2_DR_HOST,
> @@ -72,7 +76,7 @@ struct platform_device;
> 
>  struct fsl_usb2_platform_data {
>  	/* board specific information */
> -	int				controller_ver;
> +	enum fsl_usb2_controller_ver	controller_ver;
>  	enum fsl_usb2_operating_modes	operating_mode;
>  	enum fsl_usb2_phy_modes		phy_mode;
>  	unsigned int			port_enables;
> --

Hi Greg/Alan,

Could you please provide comments for this patch and the subsequent
patches in this patch set, if any.

Thanks,
Nikhil 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type
  2015-06-26 17:12 ` Badola Nikhil
@ 2015-06-26 17:40   ` gregkh
  2015-06-26 18:17   ` Alan Stern
  1 sibling, 0 replies; 4+ messages in thread
From: gregkh @ 2015-06-26 17:40 UTC (permalink / raw)
  To: Badola Nikhil; +Cc: stern, linux-usb, linux-kernel

On Fri, Jun 26, 2015 at 05:12:04PM +0000, Badola Nikhil wrote:
> > -----Original Message-----
> > From: Nikhil Badola [mailto:nikhil.badola@freescale.com]
> > Sent: Monday, June 15, 2015 3:47 PM

<snip>

> Could you please provide comments for this patch and the subsequent
> patches in this patch set, if any.

It's the middle of the merge window right now, there's nothing I can do
with this until after it is over.  Please wait until then to expect a
response, and even then, give me a week or so to dig out from under the
pending-patch load.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type
  2015-06-26 17:12 ` Badola Nikhil
  2015-06-26 17:40   ` gregkh
@ 2015-06-26 18:17   ` Alan Stern
  1 sibling, 0 replies; 4+ messages in thread
From: Alan Stern @ 2015-06-26 18:17 UTC (permalink / raw)
  To: Badola Nikhil; +Cc: gregkh, linux-usb, linux-kernel

On Fri, 26 Jun 2015, Badola Nikhil wrote:

> Hi Greg/Alan,
> 
> Could you please provide comments for this patch and the subsequent
> patches in this patch set, if any.

You shouldn't ask Greg and me; you should ask the Freescale maintainer.  
He is the person who has to approve your patches.

Alan Stern


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-06-26 19:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-15 10:16 [PATCH 1/3][v2] drivers:usb:fsl: Replace macros with enumerated type Nikhil Badola
2015-06-26 17:12 ` Badola Nikhil
2015-06-26 17:40   ` gregkh
2015-06-26 18:17   ` Alan Stern

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.