From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754097AbbFOMLK (ORCPT ); Mon, 15 Jun 2015 08:11:10 -0400 Received: from mga14.intel.com ([192.55.52.115]:39113 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753861AbbFOMLD (ORCPT ); Mon, 15 Jun 2015 08:11:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,618,1427785200"; d="scan'208";a="727596237" Message-ID: <1434370255.25843.8.camel@linux.intel.com> Subject: Re: [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS From: Alan Cox To: Dominik Brodowski Cc: linux-kernel@vger.kernel.org, linux-pcmica@lists.infradead.org Date: Mon, 15 Jun 2015 13:10:55 +0100 In-Reply-To: <20150614195246.GA13314@light.dominikbrodowski.net> References: <20141204212746.1351.89165.stgit@localhost.localdomain> <20141204213015.1351.23846.stgit@localhost.localdomain> <20150614195246.GA13314@light.dominikbrodowski.net> Organization: Intel Corporation Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Unfortunately, this patch does not work well with all of the callers of > pccard_validate_cis(). While it helps for ds.c:pcmcia_card_add() and does > not matter for cistpl.c:pccard_show_cis(), it breaks the callback in > rsrc_nonstatic.c:readable(): I'm not sure it's the right way to do readable() but we seem to be stuck with that anyway. The change looks good to me, and I will try and test it soon but it may take some time due to various other things going on in life. Can you submit it for 4.2 anyway and give it a bit of time for any screaming then push to stable ? The number of people using anonymous cards is pretty small these days so I think it's better to fix the regression you have and worry about anonymous cards as a secondary thing. Alan