All of lore.kernel.org
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Veseli Veseljko <veseljko75@gmail.com>, Alex Gal <a.gal@miip.ca>,
	Laurence Brown <linux-bluetooth@protazoa.com>,
	Szymon Janc <szymon.janc@gmail.com>
Subject: [PATCH 0/5] sixaxis: Improved support for DualShock 3 clones
Date: Mon, 15 Jun 2015 20:28:25 +0200	[thread overview]
Message-ID: <1434392910-31648-1-git-send-email-szymon.janc@gmail.com> (raw)

Hi,

This is improved version of sixaxis patches. Comparing to RFCv2 this
doesn't regress with Navigation Controller and DS4.

Sixaxis specific code needs to be left in input code for DS4 support.

If people report that this works for them I'll push those patches.


>From RFCv2 cover letter:
Some DualShock3 clones (eg ShanWan) were reported to not provide valid SDP
record required by HID profile. Due to this those failed to work with
current BlueZ sixaxis code (ie no input device were created).

This small serie is an attempt to extend DS3 support also with those
misbehaving clones. Idea is that we can provide fixed SDP recrod for devices
that use valid PID/VID and skip SDP search.

In this version SDP is kept in sixaxis plugin and provided via
btd_device_set_record instead of SDP search. Nice addition is that
sixaxis specific code is no longer needed in input server.

This makes code similar to how original Fedora sixaxis plugin worked
as suggested in previous review round.

I tested this with genuine DS3 and it seems to work OK. Testing with
clones is stil required though.


Szymon Janc (5):
  sixaxis: Fix PID for Navigation Controller
  core/device: Add support for setting SDP record
  sixaxis: Provide DualShock 3 SDP record while adding new device
  profiles/input: Remove not needed sixaxis checks
  sixaxis: Fix multi-line comments style

 Makefile.plugins        |   1 +
 plugins/sixaxis.c       | 195 ++++++++++++++++++++++++++++++++++++++++++++++--
 profiles/input/server.c |   8 --
 src/device.c            |  31 ++++++++
 src/device.h            |   3 +
 5 files changed, 224 insertions(+), 14 deletions(-)

-- 
2.1.4


             reply	other threads:[~2015-06-15 18:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 18:28 Szymon Janc [this message]
2015-06-15 18:28 ` [PATCH 1/5] sixaxis: Fix PID for Navigation Controller Szymon Janc
2015-06-15 18:45   ` simon
2015-06-15 19:47     ` Szymon Janc
2015-06-15 20:02       ` Szymon Janc
2015-06-15 20:36       ` simon
2015-06-17  3:30       ` simon
2015-06-15 18:28 ` [PATCH 2/5] core/device: Add support for setting SDP record Szymon Janc
2015-06-15 18:28 ` [PATCH 3/5] sixaxis: Provide DualShock 3 SDP record while adding new device Szymon Janc
2015-06-15 18:28 ` [PATCH 4/5] profiles/input: Remove not needed sixaxis checks Szymon Janc
2015-06-15 18:28 ` [PATCH 5/5] sixaxis: Fix multi-line comments style Szymon Janc
2015-06-21  6:25 ` [PATCH 0/5] sixaxis: Improved support for DualShock 3 clones Laurence Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434392910-31648-1-git-send-email-szymon.janc@gmail.com \
    --to=szymon.janc@gmail.com \
    --cc=a.gal@miip.ca \
    --cc=linux-bluetooth@protazoa.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=veseljko75@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.