From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 10/27] docs: Libxl migration v2 stream
	specification
Date: Tue, 16 Jun 2015 14:58:06 +0100
Message-ID: <1434463086.13744.173.camel@citrix.com>
References: <1434375880-30914-1-git-send-email-andrew.cooper3@citrix.com>
	<1434375880-30914-11-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434375880-30914-11-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-15 at 14:44 +0100, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

> +EMULATOR\_CONTEXT
> +----------------
> +
> +A context blob for a specific emulator associated with the domain.
> +
> +     0     1     2     3     4     5     6     7 octet
> +    +------------------------+------------------------+
> +    | emulator_id            | index                  |
> +    +------------------------+------------------------+
> +    | emulator_ctx                                    |
> +    ...
> +    +-------------------------------------------------+
> +
> +--------------------------------------------------------------------
> +Field            Description
> +------------     ---------------------------------------------------
> +emulator_id      0x00000000: Unknown (In the case of a legacy stream)
> +
> +                 0x00000001: Qemu Traditional
> +
> +                 0x00000002: Qemu Upstream
> +
> +                 0x00000003 - 0xFFFFFFFF: Reserved for future emulators.

Would it be useful for future proofing to carve out some space for a
per-emulator version field too?

Otherwise LGTM.

One thought, it might be useful (here or elsewhere) to have an explicit
overview of the expected control flow (as in the ownership of the fd,
and/or nesting of the layers as you prefer to think about it) between
libxc, libxl and the next layer (i.e. xl).

Ian.