From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 02/22] mg-*: Make package
 fetching common in new mgi-debian
Date: Thu, 25 Jun 2015 10:17:23 +0100
Message-ID: <1435223843.32500.3.camel@citrix.com>
References: <1435159944.28264.295.camel@citrix.com>
	<1435159961-22292-2-git-send-email-ian.campbell@citrix.com>
	<21898.54280.757380.225654@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21898.54280.757380.225654@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-24 at 17:00 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v3 02/22] mg-*: Make package fetching common in new mgi-debian"):
> > This pattern appears several times in mg-debian-installer-update and
> > I'm about to add another script which uses it.
> > 
> > The centralised version always does "sort -n -r | head -n" to pick out
> > only the newest version, which only some of the open coded sites did.
> > 
> > Likewise the centralised version checks that $pkgfile is non-empty,
> > unlike some of the open coded sites.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Although, another option would be to put this in mgi-common and call
> it "fetch_debian_package".

I'm happy either way, which would you prefer?

Ian.