From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v3 21/22] Debian: Arrange to be able to chainload a xen.efi from grub2 Date: Thu, 25 Jun 2015 12:46:12 +0100 Message-ID: <1435232772.32500.49.camel@citrix.com> References: <1435159944.28264.295.camel@citrix.com> <1435159961-22292-21-git-send-email-ian.campbell@citrix.com> <21899.55559.43212.817471@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21899.55559.43212.817471@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-25 at 11:33 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v3 21/22] Debian: Arrange to be able to chainload a xen.efi from grub2"): > > Note that the 20_linux_xen change here is a bit specific to us and not > > really generic enough to go upstream IMHO, hence I haven't. > > So if we accept this patch, we are committing to always having > 20_linux_xen (and perhaps updating it to cope with new versions of > grub). Originally having this file in osstest was intended as a > stopgap, pending inclusion of a suitable file upstream. I originally considered writing NN_osstest_uefi, but it looked like it was going to involve copying a fair bit of boilerplate from 20_linux_xen. However, I've changed the approach I was using since then and now I suspect there wouldn't actually be much duplication. So unless you think otherwise I'll try that for next time around. > Is there some upstream-friendly way of achieving the same thing ? Not AFAIK. I could try upstreaming this but given that a) the user still needs to manually copy things to the ESP and create a suitable xen.cfg and b) people are working on a better way which will just work with the existing non-UEFI grub.cfg file entries, I'm not sure how much point there is. > I'm not really sure what is `specific to us' (or what `us' here means > - osstest, or Xen on arm64, or ...?) All the paths are basically specific to us, just the general shape of the entry is more generically applicable. http://wiki.xen.org/wiki/Xen_EFI already documents how to do things FWIW. Ian.