From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbbFZH7a (ORCPT ); Fri, 26 Jun 2015 03:59:30 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:36364 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbbFZH7Y (ORCPT ); Fri, 26 Jun 2015 03:59:24 -0400 X-AuditID: cbfee690-f796f6d000005054-2c-558d064f4aca From: Maninder Singh To: airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, Jammy.Zhou@amd.com, young.yang@amd.com, samuel.li@amd.com, marek.olsak@amd.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: pankaj.m@samsung.com, Maninder Singh Subject: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree Date: Fri, 26 Jun 2015 13:26:57 +0530 Message-id: <1435305417-3276-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsWyRsSkWtefrTfUYM8ETYvecyeZLKbd2c1q 8fY+kLjy9T2bxcxPO9ksLu+aw2ZxeH4bi8XU13/ZLe692cpkcbj3PaPFmt8zmB24PVov/WXz 2P7tAavH/e7jTB59W1YxenzeJBfAGsVlk5Kak1mWWqRvl8CVcX/yRNaCW+wVe/Z1sjcwXmbr YuTgkBAwkXh6W7CLkRPIFJO4cG89UJiLQ0hgKaPExn0n2CESJhLf/65nh0gsYpQ4u7YBquon o8TKC3OZQarYBPQkVu3awwKSEBG4B1T1ZTIryApmASeJ6V/1QGqEBVwlel8uZASxWQRUJVq/ fQXr5RVwk2ib1cIIcZGCxJxJNiBjJATmsUvM7/rPBFEvIPFt8iEWiBpZiU0HmCGOk5Q4uOIG ywRGwQWMDKsYRVMLkguKk9KLTPSKE3OLS/PS9ZLzczcxAoP79L9nE3Yw3jtgfYhRgINRiYd3 55ueUCHWxLLiytxDjKZAGyYyS4km5wNjKK8k3tDYzMjC1MTU2Mjc0kxJnPe11M9gIYH0xJLU 7NTUgtSi+KLSnNTiQ4xMHJxSDYz8oSwTj6zbv+/on+2/l8Yky18TLlM6OvGs0JxZ4te78jLS np6zfjjfaaXGkRAOvssndPY/NM854Ltgg3KVnbqUgXRhR/ME5XkBd5Kfa0u5mOuoB8RH+0wK k534a3n0Aoe3WSbrgr5F603s46uptfDPPBYX27iV42Lc8ljOOPsSz4DKXoF1+UosxRmJhlrM RcWJAAqb4eVpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsVy+t9jAV1/tt5QgzN3FS16z51ksph2Zzer xdv7QOLK1/dsFjM/7WSzuLxrDpvF4fltLBZTX/9lt7j3ZiuTxeHe94wWa37PYHbg9mi99JfN Y/u3B6we97uPM3n0bVnF6PF5k1wAa1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6h pYW5kkJeYm6qrZKLT4CuW2YO0G1KCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQ QMIaxoz7kyeyFtxir9izr5O9gfEyWxcjJ4eEgInE97/r2SFsMYkL99YDxbk4hAQWMUqcXdsA 5fxklFh5YS4zSBWbgJ7Eql17WEASIgL3gKq+TGbtYuTgYBZwkpj+VQ+kRljAVaL35UJGEJtF QFWi9dtXsF5eATeJtlktjCDlEgIKEnMm2Uxg5F7AyLCKUTS1ILmgOCk910ivODG3uDQvXS85 P3cTIzh6nknvYFzVYHGIUYCDUYmHN+NjT6gQa2JZcWXuIUYJDmYlEd7Hf4BCvCmJlVWpRfnx RaU5qcWHGE2Blk9klhJNzgdGdl5JvKGxibmpsamliYWJmaWSOO/JfJ9QIYH0xJLU7NTUgtQi mD4mDk6pBkbfvTrhS5/nKa2/cjxo+5bDwTVHt66Vk23M4DV/ID7/eevlktcaEwO/zLqTvipY oWC/ylI7A9NLK38KxZmckBNb1NKy4kZWaM/E3gOO3++suHdH8LO7cGNJ68O1jIXnzHc3sOlZ sf6M3Cvpw/Rsn74v+1JOPetjKp39B9QezKrRLd3/n0U2SFqJpTgj0VCLuag4EQCP5jKKtAIA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kfree(NULL) is safe and this check is probably not required Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang Reviewed-by: Christian Konig --- v2: Chnged shortlog prefix - gpu/amdgpu drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index fec487d..a85cd08 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev) amdgpu_fence_driver_fini(adev); amdgpu_fbdev_fini(adev); r = amdgpu_fini(adev); - if (adev->ip_block_enabled) - kfree(adev->ip_block_enabled); + kfree(adev->ip_block_enabled); adev->ip_block_enabled = NULL; adev->accel_working = false; /* free i2c buses */ -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maninder Singh Subject: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree Date: Fri, 26 Jun 2015 13:26:57 +0530 Message-ID: <1435305417-3276-1-git-send-email-maninder1.s@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id 12D846E0E8 for ; Fri, 26 Jun 2015 00:59:23 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQJ01S9IKUNES00@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 26 Jun 2015 16:59:11 +0900 (KST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, Jammy.Zhou@amd.com, young.yang@amd.com, samuel.li@amd.com, marek.olsak@amd.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Maninder Singh , pankaj.m@samsung.com List-Id: dri-devel@lists.freedesktop.org a2ZyZWUoTlVMTCkgaXMgc2FmZSBhbmQgdGhpcyBjaGVjayBpcyBwcm9iYWJseSBub3QgcmVxdWly ZWQKClNpZ25lZC1vZmYtYnk6IE1hbmluZGVyIFNpbmdoIDxtYW5pbmRlcjEuc0BzYW1zdW5nLmNv bT4KUmV2aWV3ZWQtYnk6IFZhbmVldCBOYXJhbmcgPHYubmFyYW5nQHNhbXN1bmcuY29tPgpSZXZp ZXdlZC1ieTogQ2hyaXN0aWFuIEtvbmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Ci0tLQp2 MjogQ2huZ2VkIHNob3J0bG9nIHByZWZpeCAtIGdwdS9hbWRncHUKCiBkcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCAgICAzICstLQogMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9kZXZpY2UuYwppbmRleCBmZWM0ODdkLi5hODVjZDA4IDEwMDY0NAotLS0gYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKKysrIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCkBAIC0xNTc1LDggKzE1NzUsNyBAQCB2b2lk IGFtZGdwdV9kZXZpY2VfZmluaShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKIAlhbWRncHVf ZmVuY2VfZHJpdmVyX2ZpbmkoYWRldik7CiAJYW1kZ3B1X2ZiZGV2X2ZpbmkoYWRldik7CiAJciA9 IGFtZGdwdV9maW5pKGFkZXYpOwotCWlmIChhZGV2LT5pcF9ibG9ja19lbmFibGVkKQotCQlrZnJl ZShhZGV2LT5pcF9ibG9ja19lbmFibGVkKTsKKwlrZnJlZShhZGV2LT5pcF9ibG9ja19lbmFibGVk KTsKIAlhZGV2LT5pcF9ibG9ja19lbmFibGVkID0gTlVMTDsKIAlhZGV2LT5hY2NlbF93b3JraW5n ID0gZmFsc2U7CiAJLyogZnJlZSBpMmMgYnVzZXMgKi8KLS0gCjEuNy45LjUKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==