From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: [PATCH v8 00/12] Clean up pci uio implementations Date: Mon, 6 Jul 2015 15:24:09 +0900 Message-ID: <1436163861-3025-1-git-send-email-mukawa@igel.co.jp> References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> To: dev@dpdk.org Return-path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id F0A90A10 for ; Mon, 6 Jul 2015 08:25:06 +0200 (CEST) Received: by pdbci14 with SMTP id ci14so99987986pdb.2 for ; Sun, 05 Jul 2015 23:25:06 -0700 (PDT) In-Reply-To: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently Linux implementation and BSD implementation have almost same code about pci uio. This patch series cleans up it. PATCH v8 changes: - Fix comments of header file. - Fix error handling logic of resource allocation functions. (Thanks to Bruce Richardson) - Add copyright. - Fix patch description. (Thanks to Iremonger, Bernard) PATCH v7 changes: - Add below patches. Also, the order of patches are changed. - eal: Add pci_uio_alloc_resource() - eal: Add pci_uio_map_resource_by_index() - eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp - eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp - eal: Consolidate pci uio functions of linuxapp and bsdapp - eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp - eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp (Thanks to Bruce Richardson) - While adding above, below patches are not changed at all. - eal: Fix coding style of eal_pci.c and eal_pci_uio.c - eal: Close file descriptor of uio configuration - eal: Fix memory leaks and needless increment of pci_map_addr - eal/bsdapp: Change names of pci related data structure - eal: Fix uio mapping differences between linuxapp and bsdapp - some function names are changed like below. - pci_uio_alloc_uio_resource() to pci_uio_alloc_resource(). - pci_uio_map_uio_resource_by_index() to pci_uio_map_resource_by_index(). (Thanks to Iremonger, Bernard) PATCH v6 changes: - Free mapped resources in pci_uio_map_resource(). - Fix error handling in pci_uio_map_resource(). (Thanks to David, Marchand) PATCH v5 changes: - Rebase to latest master branch. PATCH v4 changes: - Rebase to latest master branch. - Fix bug in pci_uio_map_resource() of BSD code. 'maps[i].path' shouldn't be freed. Fixed in below patch: [PATCH 3/5] eal: Fix memory leaks and needless increment of pci_map_addr - 'path' member of 'struct mapped_pci_resource' should not be removed because it will be used in BSD code. Fixed in below patch: [PATCH 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp PATCH v3 changes: - Squash patches related with pci_map_resource(). - Free maps[].path to easy to understand. (Thanks to Iremonger, Bernard) - Close fds opened in this function. - Remove unused path variable from mapped_pci_resource structure. PATCH v2 changes: - Move 'if-condition' to later patch series. - Fix memory leaks of path. - Fix typos. (Thanks to David Marchand) - Fix commit title and body. - Fix pci_map_resource() to handle MAP_FAILED. (Thanks to Iremonger, Bernard) Changes: - This patch set is derived from below. "[PATCH v2] eal: Port Hotplug support for BSD" - Set cfg_fd as -1, when cfg_fd is closed. (Thanks to Iremonger, Bernard) - Remove needless coding style fixings. - Fix coding style of if-else condition. (Thanks to Richardson, Bruce) Tetsuya.Mukawa (12): eal: Fix coding style of eal_pci.c and eal_pci_uio.c eal: Close file descriptor of uio configuration eal: Fix memory leaks and needless increment of pci_map_addr eal/bsdapp: Change names of pci related data structure eal: Fix uio mapping differences between linuxapp and bsdapp eal: Add pci_uio_alloc_resource() eal: Add pci_uio_map_resource_by_index() eal: Consolidate pci_map and mapped_pci_resource of linuxapp and bsdapp eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp eal: Consolidate pci uio functions of linuxapp and bsdapp eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp lib/librte_eal/bsdapp/eal/Makefile | 2 + lib/librte_eal/bsdapp/eal/eal_pci.c | 293 ++++++--------------- .../bsdapp/eal/include/exec-env/rte_interrupts.h | 2 + lib/librte_eal/common/eal_common_pci.c | 226 ++++++++++++++++ lib/librte_eal/common/eal_common_pci_uio.c | 240 +++++++++++++++++ lib/librte_eal/common/eal_private.h | 60 ++++- lib/librte_eal/common/include/rte_pci.h | 62 +++++ lib/librte_eal/linuxapp/eal/Makefile | 2 + lib/librte_eal/linuxapp/eal/eal_pci.c | 237 +---------------- lib/librte_eal/linuxapp/eal/eal_pci_init.h | 40 +-- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 293 +++++++-------------- lib/librte_ether/rte_ethdev.c | 2 + 12 files changed, 761 insertions(+), 698 deletions(-) create mode 100644 lib/librte_eal/common/eal_common_pci_uio.c -- 2.1.4