From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v12 3/8] tools: Add vmware_hwver support
Date: Tue, 7 Jul 2015 16:59:25 +0100
Message-ID: <1436284765.25646.262.camel@citrix.com>
References: <1435447665-5433-1-git-send-email-Don.Slutz@Gmail.com>
	<1435447665-5433-4-git-send-email-Don.Slutz@Gmail.com>
	<20150701201408.GD27014@l.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150701201408.GD27014@l.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <don.slutz@gmail.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-01 at 16:14 -0400, Konrad Rzeszutek Wilk wrote:
> On Sat, Jun 27, 2015 at 07:27:40PM -0400, Don Slutz wrote:
> > From: Don Slutz <dslutz@verizon.com>
> > 
> > This is used to set xen_arch_domainconfig vmware_hw. It is set to
> > the emulated VMware virtual hardware version.
> > 
> > Currently 0, 3-4, 6-11 are good values.  However the code only
> > checks for == 0, != 0, or < 7.
> > 
> > Signed-off-by: Don Slutz <dslutz@verizon.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> > 
> >  docs/man/xl.cfg.pod.5       | 17 +++++++++++++++++
> >  tools/libxl/libxl_create.c  |  4 +++-
> >  tools/libxl/libxl_types.idl |  1 +
> >  tools/libxl/libxl_x86.c     |  3 +--
> >  tools/libxl/xl_cmdimpl.c    |  2 ++
> >  5 files changed, 24 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> > index 84078f6..4a01527 100644
> > --- a/docs/man/xl.cfg.pod.5
> > +++ b/docs/man/xl.cfg.pod.5
> > @@ -1348,6 +1348,23 @@ The viridian option can be specified as a boolean. A value of true (1)
> >  is equivalent to the list [ "defaults" ], and a value of false (0) is
> >  equivalent to an empty list.
> >  
> > +=item B<vmware_hwver=NUMBER>
> > +
> > +Turns on or off the exposure of VMware cpuid.  The number is
> > +VMware's hardware version number, where 0 is off.  A number >= 7
> > +is needed to enable exposure of VMware cpuid.
> > +
> > +The hardware version number (vmware_hwver) comes from VMware config files.
> > +
> > +=over 4
> > +
> > +In a .vmx it is virtualHW.version
> > +
> > +In a .ovf it is part of the value of vssd:VirtualSystemType.
> > +For vssd:VirtualSystemType == vmx-07, vmware_hwver = 7.
> > +
> > +=back
> > +
> 
> Perhaps add 'Recommended value is 7' ?

Assuming that is a good recommendation then that might be a good
enhancement for a future patch. Or perhaps some sort of simple mapping
from VMware product versions/names to a suitable value to use, unless
that means having to think about trademarks etc.

Ian.