From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v7 2/2] OSSTest: push successful raisin builds Date: Thu, 9 Jul 2015 16:39:58 +0100 Message-ID: <1436456398.23508.154.camel@citrix.com> References: <1434986182-3474-2-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434986182-3474-2-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-06-22 at 16:16 +0100, Stefano Stabellini wrote: > Determine the most recent raisin revision that needs to be tested, by comparing > with the already tested xen-tested-master branch. Push to > raisin.git:xen-tested-master when the build is successful. The mechanics here look right to me, but do you perhaps want to adopt the staging->master push gate scheme used in xen.git etc? This would make master (the default thing which users use) be something which has undergone at least some amount of testing. We typically use xen-tested-master for 3rd party things where the output of the test gate is mainly just for osstest's bookkeeping and not really aimed at actually users. Oh, one thing you missed is adding raisin to the default $BRANCHES at the top of cr-for-branches, without that there will be no raisin flights run and therefore no push. You might also want to considering all non-raisin build and test jobs from the raisin flight, since they are a waste of time until the raisin build results are actually used for something. You can filter tests in make-flight:job_create_test_filter_callback and for jobs you will need my "mfi-common: Allow make-*flight to filter the set of build jobs to include" patch which adds job_create_build_filter_callback. Ian.