From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 19/27] tools/libxc+libxl+xl: Restore v2
	streams
Date: Fri, 10 Jul 2015 11:45:38 +0100
Message-ID: <1436525138.23508.235.camel@citrix.com>
References: <1436466413-25867-1-git-send-email-andrew.cooper3@citrix.com>
	<1436466413-25867-20-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436466413-25867-20-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-09 at 19:26 +0100, Andrew Cooper wrote:
>  #define LIBXL_HAVE_SOCKET_BITMAP_ALLOC 1
>  
> +/*
> + * LIBXL_HAVE_STREAM_V2

These all need another word in them I think. _MIGRATION_, or _SRM_
or ... (I think I prefer SRM since migration is just one aspect)

> @@ -439,6 +447,28 @@ static void record_body_done(libxl__egc *egc,
>      stream_failed(egc, stream, ret);
>  }
>  
> +void libxl__xc_domain_restore_done(libxl__egc *egc, void *dcs_void,
> +                                   int ret, int retval, int errnoval)
> +{
> +    libxl__domain_create_state *dcs = dcs_void;
> +    STATE_AO_GC(dcs->ao);
> +
> +    if (ret)
> +        goto err;
> +
> +    if (retval) {
> +        LOGEV(ERROR, errnoval, "restoring domain");
> +        ret = ERROR_FAIL;
> +        goto err;
> +    }
> +
> +    stream_continue(egc, &dcs->srs);

This confused me briefly (done==continue??), a comment indicating that
this callback represents libxc handing back control of the fd to libxl
would maybe be useful?

With those two minor tweaks,
Acked-by: Ian Campbell <ian.campbell@citrix.com>