From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis. Date: Fri, 10 Jul 2015 03:49:25 -0700 Message-ID: <1436525365.24866.36.camel@perches.com> References: <1436521427-10568-1-git-send-email-srinivas.kandagatla@linaro.org> <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436521505-10779-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinivas Kandagatla Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Greg Kroah-Hartman , Rob Herring , Kumar Gala , Mark Brown , s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org, stefan.wahren-eS4NqCHxEME@public.gmane.org, wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Fri, 2015-07-10 at 10:45 +0100, Srinivas Kandagatla wrote: > This patch adds read/write apis which are based on nvmem_device. More trivia: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > +static struct nvmem_device *nvmem_find(const char *name) > +{ > + struct device *d; > + > + d = bus_find_device(&nvmem_bus_type, NULL, (void *)name, nvmem_match); > + > + return d ? to_nvmem_device(d) : NULL; Maybe: d = bus_find_device(...); if (!d) return NULL; return to_nvmem_device(d); > +struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id) > +{ [] > + return __nvmem_device_get(nvmem_np, NULL, NULL); > + odd blank line > +} > +EXPORT_SYMBOL_GPL(of_nvmem_device_get); > +struct nvmem_device *nvmem_device_get(struct device *dev, const char *dev_name) > +{ [] > + return nvmem_find(dev_name); > + here too > +} > +EXPORT_SYMBOL_GPL(nvmem_device_get); [] > +void devm_nvmem_device_put(struct device *dev, struct nvmem_device *nvmem) > +{ > + int ret; > + > + ret = devres_release(dev, devm_nvmem_device_release, > + devm_nvmem_device_match, nvmem); > + > + WARN_ON(ret); > + Last unnecessary blank line I'll mention (it seems to be the last one anyway) > +} > +EXPORT_SYMBOL_GPL(devm_nvmem_device_put); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932100AbbGJKtm (ORCPT ); Fri, 10 Jul 2015 06:49:42 -0400 Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:35814 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753080AbbGJKtc (ORCPT ); Fri, 10 Jul 2015 06:49:32 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3872:4321:5007:6261:6742:7904:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12679:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: trip44_3562d577dc34e X-Filterd-Recvd-Size: 2674 Message-ID: <1436525365.24866.36.camel@perches.com> Subject: Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis. From: Joe Perches To: Srinivas Kandagatla Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Rob Herring , Kumar Gala , Mark Brown , s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org, pantelis.antoniou@konsulko.com, mporter@konsulko.com, stefan.wahren@i2se.com, wxt@rock-chips.com Date: Fri, 10 Jul 2015 03:49:25 -0700 In-Reply-To: <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1436521427-10568-1-git-send-email-srinivas.kandagatla@linaro.org> <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-07-10 at 10:45 +0100, Srinivas Kandagatla wrote: > This patch adds read/write apis which are based on nvmem_device. More trivia: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > +static struct nvmem_device *nvmem_find(const char *name) > +{ > + struct device *d; > + > + d = bus_find_device(&nvmem_bus_type, NULL, (void *)name, nvmem_match); > + > + return d ? to_nvmem_device(d) : NULL; Maybe: d = bus_find_device(...); if (!d) return NULL; return to_nvmem_device(d); > +struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id) > +{ [] > + return __nvmem_device_get(nvmem_np, NULL, NULL); > + odd blank line > +} > +EXPORT_SYMBOL_GPL(of_nvmem_device_get); > +struct nvmem_device *nvmem_device_get(struct device *dev, const char *dev_name) > +{ [] > + return nvmem_find(dev_name); > + here too > +} > +EXPORT_SYMBOL_GPL(nvmem_device_get); [] > +void devm_nvmem_device_put(struct device *dev, struct nvmem_device *nvmem) > +{ > + int ret; > + > + ret = devres_release(dev, devm_nvmem_device_release, > + devm_nvmem_device_match, nvmem); > + > + WARN_ON(ret); > + Last unnecessary blank line I'll mention (it seems to be the last one anyway) > +} > +EXPORT_SYMBOL_GPL(devm_nvmem_device_put); From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Fri, 10 Jul 2015 03:49:25 -0700 Subject: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis. In-Reply-To: <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1436521427-10568-1-git-send-email-srinivas.kandagatla@linaro.org> <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <1436525365.24866.36.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2015-07-10 at 10:45 +0100, Srinivas Kandagatla wrote: > This patch adds read/write apis which are based on nvmem_device. More trivia: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > +static struct nvmem_device *nvmem_find(const char *name) > +{ > + struct device *d; > + > + d = bus_find_device(&nvmem_bus_type, NULL, (void *)name, nvmem_match); > + > + return d ? to_nvmem_device(d) : NULL; Maybe: d = bus_find_device(...); if (!d) return NULL; return to_nvmem_device(d); > +struct nvmem_device *of_nvmem_device_get(struct device_node *np, const char *id) > +{ [] > + return __nvmem_device_get(nvmem_np, NULL, NULL); > + odd blank line > +} > +EXPORT_SYMBOL_GPL(of_nvmem_device_get); > +struct nvmem_device *nvmem_device_get(struct device *dev, const char *dev_name) > +{ [] > + return nvmem_find(dev_name); > + here too > +} > +EXPORT_SYMBOL_GPL(nvmem_device_get); [] > +void devm_nvmem_device_put(struct device *dev, struct nvmem_device *nvmem) > +{ > + int ret; > + > + ret = devres_release(dev, devm_nvmem_device_release, > + devm_nvmem_device_match, nvmem); > + > + WARN_ON(ret); > + Last unnecessary blank line I'll mention (it seems to be the last one anyway) > +} > +EXPORT_SYMBOL_GPL(devm_nvmem_device_put);