From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 24/27] tools/libx{c,
 l}: Introduce restore_callbacks.checkpoint()
Date: Fri, 10 Jul 2015 12:13:46 +0100
Message-ID: <1436526826.23508.256.camel@citrix.com>
References: <1436466413-25867-1-git-send-email-andrew.cooper3@citrix.com>
	<1436466413-25867-25-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436466413-25867-25-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Wen Congyang <wency@cn.fujitsu.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-09 at 19:26 +0100, Andrew Cooper wrote:
> And call it when a checkpoint record is found in the libxc stream.
> 
> Some parts of this patch have been based on patches from the COLO series.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> 
> ---
> v2: Borrow sufficient fragments from several COLO patches to get
>     BROKEN_CHANNEL and checkpoint failover to function.
> ---
>  tools/libxc/include/xenguest.h     |    9 ++++++
>  tools/libxc/xc_sr_common.h         |    7 +++--
>  tools/libxc/xc_sr_restore.c        |   53 ++++++++++++++++++++++++++----------
>  tools/libxl/libxl_save_msgs_gen.pl |    2 +-
>  4 files changed, 53 insertions(+), 18 deletions(-)
> 
> diff --git a/tools/libxc/include/xenguest.h b/tools/libxc/include/xenguest.h
> index 7581263..8799c9f 100644
> --- a/tools/libxc/include/xenguest.h
> +++ b/tools/libxc/include/xenguest.h
> @@ -102,6 +102,15 @@ struct restore_callbacks {
>      int (*toolstack_restore)(uint32_t domid, const uint8_t *buf,
>              uint32_t size, void* data);
>  
> +    /* A checkpoint record has been found in the stream.
> +     *
> +     * returns:
> +     * 0: (error)    terminate processing
> +     * 1: (success)  continue normally

Where "continue" means "keep reading from the stream and expect more
checkpoints" (as opposed to continue on to running the guest), I think?

With that clarified: Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian