From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbbGKPwn (ORCPT ); Sat, 11 Jul 2015 11:52:43 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34317 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbbGKPwl (ORCPT ); Sat, 11 Jul 2015 11:52:41 -0400 From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Peter Zijlstra , Chris Metcalf , Thomas Gleixner , Don Zickus , Ulrich Obergfell , Andrew Morton Subject: [PATCH 1/4] smpboot: Fix memory leak on error handling Date: Sat, 11 Jul 2015 17:52:29 +0200 Message-Id: <1436629952-17291-2-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1436629952-17291-1-git-send-email-fweisbec@gmail.com> References: <1436629952-17291-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cpumask is allocated before threads get created. If the latter step fails, we need to free the cpumask. Reviewed-by: Chris Metcalf Cc: Andrew Morton Cc: Chris Metcalf Cc: Don Zickus Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ulrich Obergfell Signed-off-by: Frederic Weisbecker --- kernel/smpboot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/smpboot.c b/kernel/smpboot.c index 7c434c3..71aa90b 100644 --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -301,6 +301,7 @@ int smpboot_register_percpu_thread(struct smp_hotplug_thread *plug_thread) ret = __smpboot_create_thread(plug_thread, cpu); if (ret) { smpboot_destroy_threads(plug_thread); + free_cpumask_var(plug_thread->cpumask); goto out; } smpboot_unpark_thread(plug_thread, cpu); -- 2.1.4