All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: linux-samsung-soc@vger.kernel.org
Cc: tjakobi@math.uni-bielefeld.de,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v3 9/9] drm/exynos: return return value of exynos_crtc->enable_vblank
Date: Thu, 16 Jul 2015 12:23:39 -0300	[thread overview]
Message-ID: <1437060219-32278-9-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1437060219-32278-1-git-send-email-gustavo@padovan.org>

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Instead of blindly ignore the return value of enable_vblank return it
to the upper DRM layer for error handling.

Suggested-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
index e9c291f..9bc2353 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
@@ -175,7 +175,7 @@ int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int pipe)
 		return -EPERM;
 
 	if (exynos_crtc->ops->enable_vblank)
-		exynos_crtc->ops->enable_vblank(exynos_crtc);
+		return exynos_crtc->ops->enable_vblank(exynos_crtc);
 
 	return 0;
 }
-- 
2.1.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-07-16 15:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 15:23 [PATCH v3 1/9] drm/exynos: pass the correct pipe number Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 2/9] drm/exynos: use KMS version of DRM vblanks functions Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 3/9] drm/exynos: remove duplicated check for suspend Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 4/9] drm/exynos: rename win_commit/disable to atomic-like names Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 5/9] drm/exynos: pass struct exynos_drm_plane in update/enable Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 6/9] drm/exynos: use drm atomic state directly Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 7/9] drm/exynos: remove unused fields from struct exynos_drm_plane Gustavo Padovan
2015-07-16 15:23 ` [PATCH v3 8/9] drm/exynos: unify exynos_drm_plane names with drm core Gustavo Padovan
2015-07-16 15:23 ` Gustavo Padovan [this message]
2015-07-29 20:11 ` [PATCH v3 1/9] drm/exynos: pass the correct pipe number Gustavo Padovan
2015-07-30  4:26   ` Inki Dae
2015-08-03  8:11   ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437060219-32278-9-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.