From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 05/17] xen/arm: ITS: implement
 hw_irq_controller for LPIs
Date: Thu, 16 Jul 2015 17:37:19 +0100
Message-ID: <1437064639.32371.258.camel@citrix.com>
References: <1436514172-3263-1-git-send-email-vijay.kilari@gmail.com>
	<1436514172-3263-6-git-send-email-vijay.kilari@gmail.com>
	<55A42B1C.2030600@citrix.com>
	<CALicx6smApjaKRJHjDZYt3voVrLk-9nfinmE9Fa7gD35PKf31g@mail.gmail.com>
	<55A61940.9010408@citrix.com> <1436952729.11153.28.camel@citrix.com>
	<CALicx6tmmua2kPhoC3mAuFxnb5qmsTUwNOqnWsA3=YWwTn1W9g@mail.gmail.com>
	<1436970531.32371.96.camel@citrix.com>
	<CALicx6u4OE3nPTNLO0vkv41oKubgnSVMcQZKpAaZ9EzCGgNB+g@mail.gmail.com>
	<1437058155.32371.222.camel@citrix.com> <55A7CBF2.1030304@arm.com>
	<1437063502.32371.252.camel@citrix.com> <55A7DB85.6050506@arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A7DB85.6050506@arm.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Vijay Kilari <vijay.kilari@gmail.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "Prasun.Kapoor@caviumnetworks.com" <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Julien Grall <julien.grall@citrix.com>, "stefano.stabellini@citrix.com" <stefano.stabellini@citrix.com>, "manish.jaggi@caviumnetworks.com" <manish.jaggi@caviumnetworks.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-16 at 17:27 +0100, Marc Zyngier wrote:
> On 16/07/15 17:18, Ian Campbell wrote:
> > On Thu, 2015-07-16 at 16:21 +0100, Marc Zyngier wrote:
> >> Hope this helps,
> > 
> > It, plus the chat we had on IRC did, yes, thanks.
> > 
> > In summary:
> > 
> > I was very confusedly talking about INV when I meant SYNC.
> > 
> > There is a real issue with the update of its_dev->collection in
> > its_set_affinity since it will result in the wrong collection being used
> > for subsequent affinity operations.
> 
> Yeah, this is a very stupid bug on my side, and I realize that I never
> saw it because the whole ITS driver has been written on a model that can
> only generate a single interrupt per device. Lovely.

Oh dear!

> > Marc is intending to replace its_dev->collection with an array
> > (presumably dynamically allocated) in its_dev mapping eventid to a
> > collection.
> 
> Exactly.
> 
> > I think that is probably the right answer for Xen too.
> 
> I'd think so.
> 
> Thanks so much for putting me right!

No problem!

Ian.