All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@fb.com>
Cc: Alexander Graf <agraf@suse.com>, Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field
Date: Fri, 17 Jul 2015 09:27:07 +0200	[thread overview]
Message-ID: <1437118027-94602-5-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1437118027-94602-1-git-send-email-hare@suse.de>

The current LOOP_SET_STATUS64 ioctl has two unused fields
'init[2]', which can be used in conjunction with the
LO_FLAGS_BLOCKSIZE flag to pass in the new logical blocksize.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/block/loop.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 321f296..3d2ee0f 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -963,11 +963,21 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	if (err)
 		return err;
 
-	if (info->lo_flags & LO_FLAGS_BLOCKSIZE)
+	if (info->lo_flags & LO_FLAGS_BLOCKSIZE) {
 		lo->lo_flags |= LO_FLAGS_BLOCKSIZE;
+		if ((info->lo_init[0] != 512) &&
+		    (info->lo_init[0] != 1024) &&
+		    (info->lo_init[0] != 2048) &&
+		    (info->lo_init[0] != 4096))
+			return -EINVAL;
+		if (info->lo_init[0] > lo->lo_blocksize)
+			return -EINVAL;
+		lo->lo_logical_blocksize = info->lo_init[0];
+	}
 
 	if (lo->lo_offset != info->lo_offset ||
-	    lo->lo_sizelimit != info->lo_sizelimit)
+	    lo->lo_sizelimit != info->lo_sizelimit ||
+	    lo->lo_flags & LO_FLAGS_BLOCKSIZE)
 		if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit))
 			return -EFBIG;
 
-- 
1.8.5.2


  parent reply	other threads:[~2015-07-17  7:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17  7:27 [PATCH 0/4] loop: enable different physical blocksizes Hannes Reinecke
2015-07-17  7:27 ` [PATCH 1/4] loop: Enable correct physical blocksize Hannes Reinecke
2015-07-27  5:15   ` Christoph Hellwig
2015-07-27  5:59     ` Hannes Reinecke
2015-08-07  7:31       ` Christoph Hellwig
2015-07-17  7:27 ` [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity Hannes Reinecke
2015-07-27  5:16   ` Christoph Hellwig
2015-07-17  7:27 ` [PATCH 3/4] loop: Add 'lo_logical_blocksize' Hannes Reinecke
2015-07-17  7:27 ` Hannes Reinecke [this message]
2015-07-27 10:40 ` [PATCH 0/4] loop: enable different physical blocksizes Ming Lei
2015-08-03 23:00   ` Alexander Graf
2015-08-07  5:07     ` Ming Lei
2015-08-07  6:46       ` Hannes Reinecke
2015-08-07  7:23         ` Ming Lei
2015-08-07  7:45           ` Hannes Reinecke
2015-08-07  8:02             ` Ming Lei
2015-08-07  7:33   ` Christoph Hellwig
2015-08-07  7:44     ` Ming Lei
2015-08-07  7:48       ` Christoph Hellwig
2015-08-07  7:58         ` Ming Lei
2015-08-07  7:50       ` Hannes Reinecke
2015-08-07  8:54 [PATCHv2 " Hannes Reinecke
2015-08-07  8:54 ` [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field Hannes Reinecke
2015-11-10  8:13 [PATCHv3 0/4] loop: enable different physical blocksizes Hannes Reinecke
2015-11-10  8:13 ` [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field Hannes Reinecke
2015-11-13 21:42   ` Jeff Moyer
2016-10-31 19:37 [PATCHv3 0/4] loop: enable different physical blocksizes Hannes Reinecke
2016-10-31 19:37 ` [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field Hannes Reinecke
2016-11-01 14:02   ` Christoph Hellwig
2016-11-01 16:58     ` Hannes Reinecke
2016-11-03 13:26     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437118027-94602-5-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=agraf@suse.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.