From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Liu Subject: [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free Date: Tue, 21 Jul 2015 11:30:40 +0800 Message-ID: <1437449441-2964-2-git-send-email-bob.liu__47833.6473032416$1437449567$gmane$org@oracle.com> References: <1437449441-2964-1-git-send-email-bob.liu@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHOGj-0006M2-6D for xen-devel@lists.xenproject.org; Tue, 21 Jul 2015 03:31:01 +0000 In-Reply-To: <1437449441-2964-1-git-send-email-bob.liu@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Bob Liu , roger.pau@citrix.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info->indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index e266d17..c98fcd0 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -986,7 +986,6 @@ static void blkif_free(struct blkfront_info *info, int suspend) if (!list_empty(&info->indirect_pages)) { struct page *indirect_page, *n; - BUG_ON(info->feature_persistent); list_for_each_entry_safe(indirect_page, n, &info->indirect_pages, lru) { list_del(&indirect_page->lru); __free_page(indirect_page); -- 1.7.10.4