All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] base-passwd: set root's default password to 'root'
Date: Tue, 29 Nov 2016 19:27:32 +1300	[thread overview]
Message-ID: <14375940.ArtjuEAhVL@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <90784e81-531a-1da8-4660-e4946916ca69@windriver.com>

On Tue, 29 Nov 2016 13:36:58 Robert Yang wrote:
> On 11/29/2016 11:45 AM, Paul Eggleton wrote:
> > On Tue, 29 Nov 2016 10:45:51 Robert Yang wrote:
> >> We may also need something like IMAGE_FEATURES += "test" to make it can
> >> work with -ctestimage.
> > 
> > Not sure I follow your reasoning here - can you explain what this feature
> > would do?
> 
> For example, the "bitbake <image> -ctestimage" requires a few pkgs
> installed, such as psplash-default, see the testcase in
> meta/lib/oeqa/runtime/smart.py:
> 
>      def test_smart_install(self):
>          self.smart('remove -y psplash-default')
>          self.smart('install -y psplash-default')
> 
> The test would fail without psplash-default installed, and also it requires
> sshd installed on the target. When IMAGE_FETURES += "test", we can install
> these required packages, I'm not sure this is a good idea, or maybe we can
> enhance testimge.bbclass to do it. Another way to fix the problem might be
> not hardcode the package name.

We have other means of dealing with that specifically - i.e. have the test 
skip itself if a package required for the test is not in the image. I think we 
already have examples of that.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2016-11-29  6:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  7:49 [PATCH 0/2] fix can't login when debug-tweaks is not in IMAGE_FEATURES Robert Yang
2016-11-23  7:49 ` [PATCH 1/2] rootfs-postcommands.bbclass: fix zap_empty_root_password Robert Yang
2016-11-23  7:49 ` [PATCH 2/2] base-passwd: set root's default password to 'root' Robert Yang
2016-11-23 11:16   ` Patrick Ohly
2016-11-23 14:17     ` Burton, Ross
2016-11-24  2:01     ` Robert Yang
2016-11-24  3:18       ` Paul Eggleton
2016-11-24  3:38         ` Robert Yang
2016-11-24  7:46           ` Patrick Ohly
2016-11-24  8:27             ` Robert Yang
2016-11-24 14:09             ` Philip Balister
2016-11-24 14:54               ` Patrick Ohly
2016-11-24 18:59             ` Paul Eggleton
2016-11-29  1:57               ` Khem Raj
2016-11-29  2:45                 ` Robert Yang
2016-11-29  3:45                   ` Paul Eggleton
2016-11-29  5:36                     ` Robert Yang
2016-11-29  6:27                       ` Paul Eggleton [this message]
2016-11-24  7:51       ` Mike Looijmans
2016-11-30  3:15 ` [PATCH 0/2] fix can't login when debug-tweaks is not in IMAGE_FEATURES Robert Yang
2016-11-30  9:28   ` ChenQi
2016-11-30  9:32     ` ChenQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14375940.ArtjuEAhVL@peggleto-mobl.ger.corp.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.