All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	David Vrabel <david.vrabel@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages
Date: Fri, 24 Jul 2015 12:47:48 +0100	[thread overview]
Message-ID: <1437738468-24110-11-git-send-email-david.vrabel__31683.5319078111$1437740187$gmane$org@citrix.com> (raw)
In-Reply-To: <1437738468-24110-1-git-send-email-david.vrabel@citrix.com>

Pages returned by alloc_xenballooned_pages() will be used for grant
mapping which will call set_phys_to_machine() (in PV guests).

Ballooned pages are set as INVALID_P2M_ENTRY in the p2m and thus may
be using the (shared) missing tables and a subsequent
set_phys_to_machine() will need to allocate new tables.

Since the grant mapping may be done from a context that cannot sleep,
the p2m entries must already be allocated.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
 drivers/xen/balloon.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index fd6970f3..8932d10 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -541,6 +541,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
 {
 	int pgno = 0;
 	struct page *page;
+	int ret = -ENOMEM;
 
 	mutex_lock(&balloon_mutex);
 
@@ -550,6 +551,11 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
 		page = balloon_retrieve(true);
 		if (page) {
 			pages[pgno++] = page;
+#ifdef CONFIG_XEN_HAVE_PVMMU
+			ret = xen_alloc_p2m_entry(page_to_pfn(page));
+			if (ret < 0)
+				goto out_undo;
+#endif
 		} else {
 			enum bp_state st;
 
@@ -576,7 +582,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
  out_undo:
 	mutex_unlock(&balloon_mutex);
 	free_xenballooned_pages(pgno, pages);
-	return -ENOMEM;
+	return ret;
 }
 EXPORT_SYMBOL(alloc_xenballooned_pages);
 
-- 
2.1.4

  parent reply	other threads:[~2015-07-24 12:15 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 11:47 [PATCHv2 00/10] mm, xen/balloon: memory hotplug improvements David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 01/10] mm: memory hotplug with an existing resource David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-28 14:54   ` Daniel Kiper
2015-07-28 14:54   ` Daniel Kiper
2015-07-28 14:54     ` Daniel Kiper
2015-07-24 11:47 ` [PATCHv2 02/10] xen/balloon: remove scratch page left overs David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 03/10] x86/xen: discard RAM regions above the maximum reservation David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 04/10] xen/balloon: find non-conflicting regions to place hotplugged memory David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 05/10] xen/balloon: rationalize memory hotplug stats David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 18:54   ` Konrad Rzeszutek Wilk
2015-07-24 18:54   ` Konrad Rzeszutek Wilk
2015-07-24 18:54     ` Konrad Rzeszutek Wilk
2015-07-28 15:22   ` Daniel Kiper
2015-07-28 15:22   ` Daniel Kiper
2015-07-28 15:22     ` Daniel Kiper
2015-07-24 11:47 ` [PATCHv2 06/10] xen/balloon: only hotplug additional memory if required David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-29 15:55   ` Daniel Kiper
2015-07-29 15:55   ` Daniel Kiper
2015-07-29 15:55     ` Daniel Kiper
2015-07-29 16:02     ` David Vrabel
2015-07-29 16:02       ` David Vrabel
2015-07-29 16:02     ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 07/10] xen/balloon: make alloc_xenballoon_pages() always allocate low pages David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 08/10] xen/balloon: use hotplugged pages for foreign mappings etc David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 18:55   ` Konrad Rzeszutek Wilk
2015-07-24 18:55     ` Konrad Rzeszutek Wilk
2015-07-27 10:18     ` David Vrabel
2015-07-27 10:18     ` [Xen-devel] " David Vrabel
2015-07-27 10:18       ` David Vrabel
2015-07-24 18:55   ` Konrad Rzeszutek Wilk
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 09/10] x86/xen: export xen_alloc_p2m_entry() David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 18:51   ` Konrad Rzeszutek Wilk
2015-07-24 18:51     ` Konrad Rzeszutek Wilk
2015-07-24 18:51   ` Konrad Rzeszutek Wilk
2015-07-29 16:10   ` Daniel Kiper
2015-07-29 16:10   ` Daniel Kiper
2015-07-29 16:10     ` Daniel Kiper
2015-07-24 11:47 ` David Vrabel
2015-07-24 11:47 ` [PATCHv2 10/10] xen/balloon: pre-allocate p2m entries for ballooned pages David Vrabel
2015-07-24 11:47   ` David Vrabel
2015-07-24 23:21   ` Julien Grall
2015-07-24 23:21   ` [Xen-devel] " Julien Grall
2015-07-24 23:21     ` Julien Grall
2015-07-27  9:30     ` David Vrabel
2015-07-27  9:30     ` [Xen-devel] " David Vrabel
2015-07-27  9:30       ` David Vrabel
2015-07-27 11:01       ` Julien Grall
2015-07-27 11:01         ` Julien Grall
2015-07-27 12:40         ` David Vrabel
2015-07-27 12:40           ` David Vrabel
2015-07-27 12:40         ` David Vrabel
2015-07-27 11:01       ` Julien Grall
2015-07-24 11:47 ` David Vrabel [this message]
2015-07-27 19:37 ` [PATCHv2 00/10] mm, xen/balloon: memory hotplug improvements Daniel Kiper
2015-07-27 19:37 ` Daniel Kiper
2015-07-27 19:37   ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1437738468-24110-11-git-send-email-david.vrabel__31683.5319078111$1437740187$gmane$org@citrix.com' \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.