* [PATCH] serial: etraxfs-uart: remove empty functions
@ 2015-07-25 0:00 Niklas Cassel
2015-08-01 15:00 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2015-07-25 0:00 UTC (permalink / raw)
To: gregkh; +Cc: jslaby, linux-serial, linux-kernel, Niklas Cassel
Implementing enable_ms is optional by serial_core.
check_modem_status is just an empty local function.
Signed-off-by: Niklas Cassel <nks@flawful.org>
---
drivers/tty/serial/etraxfs-uart.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/tty/serial/etraxfs-uart.c b/drivers/tty/serial/etraxfs-uart.c
index 679709f..a647605 100644
--- a/drivers/tty/serial/etraxfs-uart.c
+++ b/drivers/tty/serial/etraxfs-uart.c
@@ -373,14 +373,6 @@ static void etraxfs_uart_stop_rx(struct uart_port *port)
REG_WR(ser, regi_ser, rw_rec_ctrl, rec_ctrl);
}
-static void etraxfs_uart_enable_ms(struct uart_port *port)
-{
-}
-
-static void check_modem_status(struct uart_cris_port *up)
-{
-}
-
static unsigned int etraxfs_uart_tx_empty(struct uart_port *port)
{
struct uart_cris_port *up = (struct uart_cris_port *)port;
@@ -598,7 +590,6 @@ ser_interrupt(int irq, void *dev_id)
receive_chars_no_dma(up);
handled = 1;
}
- check_modem_status(up);
if (masked_intr.tr_rdy) {
transmit_chars_no_dma(up);
@@ -862,7 +853,6 @@ static const struct uart_ops etraxfs_uart_pops = {
.start_tx = etraxfs_uart_start_tx,
.send_xchar = etraxfs_uart_send_xchar,
.stop_rx = etraxfs_uart_stop_rx,
- .enable_ms = etraxfs_uart_enable_ms,
.break_ctl = etraxfs_uart_break_ctl,
.startup = etraxfs_uart_startup,
.shutdown = etraxfs_uart_shutdown,
--
2.4.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: etraxfs-uart: remove empty functions
2015-07-25 0:00 [PATCH] serial: etraxfs-uart: remove empty functions Niklas Cassel
@ 2015-08-01 15:00 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-08-01 15:00 UTC (permalink / raw)
To: Niklas Cassel; +Cc: gregkh, jslaby, linux-serial, linux-kernel
On Sat, Jul 25, 2015 at 02:00:40AM +0200, Niklas Cassel wrote:
> Implementing enable_ms is optional by serial_core.
> check_modem_status is just an empty local function.
>
> Signed-off-by: Niklas Cassel <nks@flawful.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-01 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-25 0:00 [PATCH] serial: etraxfs-uart: remove empty functions Niklas Cassel
2015-08-01 15:00 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.