All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: linux-samsung-soc@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
	jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [PATCH v2 07/11] drm/exynos: remove extra call to exynos_dp_commit()
Date: Wed,  5 Aug 2015 20:24:18 -0300	[thread overview]
Message-ID: <1438817060-22164-8-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1438817060-22164-1-git-send-email-gustavo@padovan.org>

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

exynos_dp_commit() was getting called twice by exynos encoder core, once
inside the .enable() call and another time by .commit() itself.

The remove of the second call caused the wake of a bug, the operations
orders inside exynos_dp_commit was wrong and we had to move
exynos_dp_start_video() to be the last operation in there.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/gpu/drm/exynos/exynos_dp_core.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 002a233..6d9d115 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -795,9 +795,6 @@ static int exynos_dp_config_video(struct exynos_dp_device *dp)
 	/* Configure video slave mode */
 	exynos_dp_enable_video_master(dp, 0);
 
-	/* Enable video */
-	exynos_dp_start_video(dp);
-
 	timeout_loop = 0;
 
 	for (;;) {
@@ -938,6 +935,9 @@ static void exynos_dp_commit(struct exynos_drm_encoder *encoder)
 		if (drm_panel_enable(dp->panel))
 			DRM_ERROR("failed to enable the panel\n");
 	}
+
+	/* Enable video */
+	exynos_dp_start_video(dp);
 }
 
 static enum drm_connector_status exynos_dp_detect(
@@ -1110,7 +1110,6 @@ static struct exynos_drm_encoder_ops exynos_dp_encoder_ops = {
 	.create_connector = exynos_dp_create_connector,
 	.enable = exynos_dp_enable,
 	.disable = exynos_dp_disable,
-	.commit = exynos_dp_commit,
 };
 
 static struct video_info *exynos_dp_dt_parse_pdata(struct device *dev)
-- 
2.1.0

  parent reply	other threads:[~2015-08-05 23:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 23:24 [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 01/11] drm/exynos: split display's .dpms() into .enable() and .disable() Gustavo Padovan
2015-08-11  0:37   ` [PATCH " Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 02/11] drm/exynos: remove wrappers for phy_power_{on,off} Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 03/11] drm/exynos: remove unused .remove() and .check_mode() ops from display Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 04/11] drm/exynos: simplify calculation of possible CRTCs Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 05/11] drm/exynos: remove struct exynos_drm_display Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 06/11] drm/exynos: remove extra call to hdmi_commit() Gustavo Padovan
2015-08-05 23:24 ` Gustavo Padovan [this message]
2015-08-05 23:24 ` [PATCH v2 08/11] drm/exynos: remove exynos_encoder's .commit() op Gustavo Padovan
2015-08-05 23:24 ` [PATCH v2 09/11] drm/exynos: remove exynos_drm_create_enc_conn() Gustavo Padovan
2015-08-06 13:31   ` [PATCH v2 10/11] drm/exynos: fold encoder setup into exynos_drm_load() Gustavo Padovan
2015-08-06 13:31     ` [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer Gustavo Padovan
2015-08-07 11:50       ` Inki Dae
2015-08-07 12:28         ` Daniel Vetter
2015-08-07 13:22           ` Inki Dae
2015-08-11  0:38         ` Gustavo Padovan
2015-08-11 12:13           ` Inki Dae
2015-08-11 15:03             ` Daniel Vetter
2015-08-12  2:53               ` Inki Dae
2015-08-12 15:49             ` Gustavo Padovan
2015-08-12 15:54               ` Gustavo Padovan
2015-08-15 14:33                 ` Inki Dae
2015-08-15 15:22                   ` Gustavo Padovan
2015-08-15 15:14       ` [PATCH -v3 " Gustavo Padovan
2015-08-06 11:55 ` [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder Inki Dae
2015-08-06 13:27   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438817060-22164-8-git-send-email-gustavo@padovan.org \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.