From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau Monne Subject: [PATCH v4 01/31] libxl: fix libxl__build_hvm error handling Date: Fri, 7 Aug 2015 12:17:38 +0200 Message-ID: <1438942688-7610-2-git-send-email-roger.pau@citrix.com> References: <1438942688-7610-1-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZNejE-0006Dk-7l for xen-devel@lists.xenproject.org; Fri, 07 Aug 2015 10:18:20 +0000 In-Reply-To: <1438942688-7610-1-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Wei Liu , Stefano Stabellini , Ian Jackson , Ian Campbell , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org V2l0aCB0aGUgY3VycmVudCBjb2RlIGluIGxpYnhsX19idWlsZF9odm0gaXQgaXMgcG9zc2libGUg Zm9yIHRoZSBmdW5jdGlvbiB0bwpmYWlsIGFuZCBzdGlsbCByZXR1cm4gMC4KClNpZ25lZC1vZmYt Ynk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpDYzogSWFuIEphY2tz b24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+CkNjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0 ZWZhbm8uc3RhYmVsbGluaUBldS5jaXRyaXguY29tPgpDYzogSWFuIENhbXBiZWxsIDxpYW4uY2Ft cGJlbGxAY2l0cml4LmNvbT4KQ2M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Ci0tLQog dG9vbHMvbGlieGwvbGlieGxfZG9tLmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9kb20uYyBiL3Rvb2xzL2xpYnhs L2xpYnhsX2RvbS5jCmluZGV4IGUxZjExYTMuLjM4ZmI5MzkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xp YnhsL2xpYnhsX2RvbS5jCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2RvbS5jCkBAIC03NjYsNyAr NzY2LDcgQEAgc3RhdGljIGludCBodm1fYnVpbGRfc2V0X3BhcmFtcyh4Y19pbnRlcmZhY2UgKmhh bmRsZSwgdWludDMyX3QgZG9taWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg WENfUEFHRV9TSVpFLCBQUk9UX1JFQUQgfCBQUk9UX1dSSVRFLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIEhWTV9JTkZPX1BGTik7CiAgICAgaWYgKHZhX21hcCA9PSBOVUxMKQot ICAgICAgICByZXR1cm4gLTE7CisgICAgICAgIHJldHVybiBFUlJPUl9GQUlMOwogCiAgICAgdmFf aHZtID0gKHN0cnVjdCBodm1faW5mb190YWJsZSAqKSh2YV9tYXAgKyBIVk1fSU5GT19PRkZTRVQp OwogICAgIHZhX2h2bS0+YXBpY19tb2RlID0gbGlieGxfZGVmYm9vbF92YWwoaW5mby0+dS5odm0u YXBpYyk7CkBAIC05MTIsNyArOTEyLDcgQEAgaW50IGxpYnhsX19idWlsZF9odm0obGlieGxfX2dj ICpnYywgdWludDMyX3QgZG9taWQsCiB7CiAgICAgbGlieGxfY3R4ICpjdHggPSBsaWJ4bF9fZ2Nf b3duZXIoZ2MpOwogICAgIHN0cnVjdCB4Y19odm1fYnVpbGRfYXJncyBhcmdzID0ge307Ci0gICAg aW50IHJldCwgcmMgPSBFUlJPUl9GQUlMOworICAgIGludCByZXQsIHJjOwogICAgIHVpbnQ2NF90 IG1taW9fc3RhcnQsIGxvd21lbV9lbmQsIGhpZ2htZW1fZW5kOwogICAgIGxpYnhsX2RvbWFpbl9i dWlsZF9pbmZvICpjb25zdCBpbmZvID0gJmRfY29uZmlnLT5iX2luZm87CiAKQEAgLTkzMiw3ICs5 MzIsOSBAQCBpbnQgbGlieGxfX2J1aWxkX2h2bShsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21p ZCwKICAgICAgICAgaWYgKG1heF9yYW1fYmVsb3dfNGcgPCBIVk1fQkVMT1dfNEdfTU1JT19TVEFS VCkKICAgICAgICAgICAgIGFyZ3MubW1pb19zaXplID0gaW5mby0+dS5odm0ubW1pb19ob2xlX21l bWtiIDw8IDEwOwogICAgIH0KLSAgICBpZiAobGlieGxfX2RvbWFpbl9maXJtd2FyZShnYywgaW5m bywgJmFyZ3MpKSB7CisKKyAgICByYyA9IGxpYnhsX19kb21haW5fZmlybXdhcmUoZ2MsIGluZm8s ICZhcmdzKTsKKyAgICBpZiAocmMgIT0gMCkgewogICAgICAgICBMT0coRVJST1IsICJpbml0aWFs aXppbmcgZG9tYWluIGZpcm13YXJlIGZhaWxlZCIpOwogICAgICAgICBnb3RvIG91dDsKICAgICB9 CkBAIC05NjMsMTUgKzk2NSwxNSBAQCBpbnQgbGlieGxfX2J1aWxkX2h2bShsaWJ4bF9fZ2MgKmdj LCB1aW50MzJfdCBkb21pZCwKICAgICBpZiAoaW5mby0+bnVtX3ZudW1hX25vZGVzICE9IDApIHsK ICAgICAgICAgaW50IGk7CiAKLSAgICAgICAgcmV0ID0gbGlieGxfX3ZudW1hX2J1aWxkX3ZtZW1y YW5nZV9odm0oZ2MsIGRvbWlkLCBpbmZvLCBzdGF0ZSwgJmFyZ3MpOwotICAgICAgICBpZiAocmV0 KSB7Ci0gICAgICAgICAgICBMT0dFVihFUlJPUiwgcmV0LCAiaHZtIGJ1aWxkIHZtZW1yYW5nZXMg ZmFpbGVkIik7CisgICAgICAgIHJjID0gbGlieGxfX3ZudW1hX2J1aWxkX3ZtZW1yYW5nZV9odm0o Z2MsIGRvbWlkLCBpbmZvLCBzdGF0ZSwgJmFyZ3MpOworICAgICAgICBpZiAocmMgIT0gMCkgewor ICAgICAgICAgICAgTE9HKEVSUk9SLCAiaHZtIGJ1aWxkIHZtZW1yYW5nZXMgZmFpbGVkIik7CiAg ICAgICAgICAgICBnb3RvIG91dDsKICAgICAgICAgfQotICAgICAgICByZXQgPSBsaWJ4bF9fdm51 bWFfY29uZmlnX2NoZWNrKGdjLCBpbmZvLCBzdGF0ZSk7Ci0gICAgICAgIGlmIChyZXQpIGdvdG8g b3V0OwotICAgICAgICByZXQgPSBzZXRfdm51bWFfaW5mbyhnYywgZG9taWQsIGluZm8sIHN0YXRl KTsKLSAgICAgICAgaWYgKHJldCkgZ290byBvdXQ7CisgICAgICAgIHJjID0gbGlieGxfX3ZudW1h X2NvbmZpZ19jaGVjayhnYywgaW5mbywgc3RhdGUpOworICAgICAgICBpZiAocmMgIT0gMCkgZ290 byBvdXQ7CisgICAgICAgIHJjID0gc2V0X3ZudW1hX2luZm8oZ2MsIGRvbWlkLCBpbmZvLCBzdGF0 ZSk7CisgICAgICAgIGlmIChyYyAhPSAwKSBnb3RvIG91dDsKIAogICAgICAgICBhcmdzLm5yX3Zt ZW1yYW5nZXMgPSBzdGF0ZS0+bnVtX3ZtZW1yYW5nZXM7CiAgICAgICAgIGFyZ3Mudm1lbXJhbmdl cyA9IGxpYnhsX19tYWxsb2MoZ2MsIHNpemVvZigqYXJncy52bWVtcmFuZ2VzKSAqCkBAIC05OTQs MzEgKzk5NiwzNCBAQCBpbnQgbGlieGxfX2J1aWxkX2h2bShsaWJ4bF9fZ2MgKmdjLCB1aW50MzJf dCBkb21pZCwKICAgICByZXQgPSB4Y19odm1fYnVpbGQoY3R4LT54Y2gsIGRvbWlkLCAmYXJncyk7 CiAgICAgaWYgKHJldCkgewogICAgICAgICBMT0dFVihFUlJPUiwgcmV0LCAiaHZtIGJ1aWxkaW5n IGZhaWxlZCIpOworICAgICAgICByYyA9IEVSUk9SX0ZBSUw7CiAgICAgICAgIGdvdG8gb3V0Owog ICAgIH0KIAotICAgIGlmIChsaWJ4bF9fYXJjaF9kb21haW5fY29uc3RydWN0X21lbW1hcChnYywg ZF9jb25maWcsIGRvbWlkLCAmYXJncykpIHsKKyAgICByYyA9IGxpYnhsX19hcmNoX2RvbWFpbl9j b25zdHJ1Y3RfbWVtbWFwKGdjLCBkX2NvbmZpZywgZG9taWQsICZhcmdzKTsKKyAgICBpZiAocmMg IT0gMCkgewogICAgICAgICBMT0coRVJST1IsICJzZXR0aW5nIGRvbWFpbiBtZW1vcnkgbWFwIGZh aWxlZCIpOwogICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICByZXQgPSBodm1fYnVpbGRf c2V0X3BhcmFtcyhjdHgtPnhjaCwgZG9taWQsIGluZm8sIHN0YXRlLT5zdG9yZV9wb3J0LAorICAg IHJjID0gaHZtX2J1aWxkX3NldF9wYXJhbXMoY3R4LT54Y2gsIGRvbWlkLCBpbmZvLCBzdGF0ZS0+ c3RvcmVfcG9ydCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmc3RhdGUtPnN0b3Jl X21mbiwgc3RhdGUtPmNvbnNvbGVfcG9ydCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAmc3RhdGUtPmNvbnNvbGVfbWZuLCBzdGF0ZS0+c3RvcmVfZG9taWQsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc3RhdGUtPmNvbnNvbGVfZG9taWQpOwotICAgIGlmIChyZXQpIHsK LSAgICAgICAgTE9HRVYoRVJST1IsIHJldCwgImh2bSBidWlsZCBzZXQgcGFyYW1zIGZhaWxlZCIp OworICAgIGlmIChyYyAhPSAwKSB7CisgICAgICAgIExPRyhFUlJPUiwgImh2bSBidWlsZCBzZXQg cGFyYW1zIGZhaWxlZCIpOwogICAgICAgICBnb3RvIG91dDsKICAgICB9CiAKLSAgICByZXQgPSBo dm1fYnVpbGRfc2V0X3hzX3ZhbHVlcyhnYywgZG9taWQsICZhcmdzKTsKLSAgICBpZiAocmV0KSB7 Ci0gICAgICAgIExPRyhFUlJPUiwgImh2bSBidWlsZCBzZXQgeGVuc3RvcmUgdmFsdWVzIGZhaWxl ZCAocmV0PSVkKSIsIHJldCk7CisgICAgcmMgPSBodm1fYnVpbGRfc2V0X3hzX3ZhbHVlcyhnYywg ZG9taWQsICZhcmdzKTsKKyAgICBpZiAocmMgIT0gMCkgeworICAgICAgICBMT0coRVJST1IsICJo dm0gYnVpbGQgc2V0IHhlbnN0b3JlIHZhbHVlcyBmYWlsZWQiKTsKICAgICAgICAgZ290byBvdXQ7 CiAgICAgfQogCiAgICAgcmV0dXJuIDA7CiBvdXQ6CisgICAgYXNzZXJ0KHJjICE9IDApOwogICAg IHJldHVybiByYzsKIH0KIAotLSAKMS45LjUgKEFwcGxlIEdpdC01MC4zKQoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs Cg==