All of lore.kernel.org
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: acme@kernel.org, jolsa@kernel.org
Cc: linux-kernel@vger.kernel.org, Kan Liang <kan.liang@intel.com>
Subject: [PATCH 1/1] perf,tools: open event on evsel cpus and threads
Date: Fri, 21 Aug 2015 02:23:14 -0400	[thread overview]
Message-ID: <1440138194-17001-1-git-send-email-kan.liang@intel.com> (raw)

From: Kan Liang <kan.liang@intel.com>

evsel may have different cpus and threads as evlist's.
Use it's own cpus and threads, when open evsel in perf record.

Signed-off-by: Kan Liang <kan.liang@intel.com>
---
 tools/perf/builtin-record.c | 2 +-
 tools/perf/util/evlist.c    | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 25cf6b4..a0178bf 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -279,7 +279,7 @@ static int record__open(struct record *rec)
 
 	evlist__for_each(evlist, pos) {
 try_again:
-		if (perf_evsel__open(pos, evlist->cpus, evlist->threads) < 0) {
+		if (perf_evsel__open(pos, pos->cpus, pos->threads) < 0) {
 			if (perf_evsel__fallback(pos, errno, msg, sizeof(msg))) {
 				if (verbose)
 					ui__warning("%s\n", msg);
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 373f65b..be6fde9 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1179,6 +1179,10 @@ int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **e
 		if (evsel->filter == NULL)
 			continue;
 
+		/*
+		 * filters only work for tracepoint event, which doesn't have cpu limit.
+		 * So evlist and evsel should always be same.
+		 */
 		err = perf_evsel__apply_filter(evsel, ncpus, nthreads, evsel->filter);
 		if (err) {
 			*err_evsel = evsel;
-- 
1.8.3.1


             reply	other threads:[~2015-08-21 13:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21  6:23 kan.liang [this message]
2015-08-21 13:54 ` [PATCH 1/1] perf,tools: open event on evsel cpus and threads Jiri Olsa
2015-08-31 20:31   ` Arnaldo Carvalho de Melo
2015-08-31 21:06     ` Liang, Kan
2015-08-31 21:14       ` Arnaldo Carvalho de Melo
2015-08-31 21:28         ` Liang, Kan
2015-08-31 21:34           ` Arnaldo Carvalho de Melo
2015-09-01  8:31 ` [tip:perf/urgent] perf evlist: Open " tip-bot for Kan Liang
2015-09-03 13:34   ` Adrian Hunter
2015-09-03 15:27     ` Arnaldo Carvalho de Melo
2015-09-03 16:23       ` Adrian Hunter
2015-09-03 16:41         ` Arnaldo Carvalho de Melo
2015-09-03 18:19           ` Jiri Olsa
2015-09-03 18:38             ` Adrian Hunter
2015-09-03 19:04               ` Jiri Olsa
2015-09-03 20:41             ` Arnaldo Carvalho de Melo
2015-09-04  7:05               ` Jiri Olsa
2015-09-04  7:09                 ` Adrian Hunter
2015-09-04 12:15                   ` [PATCH] perf tools: Fix gaps propagating maps Adrian Hunter
2015-09-04 13:28                     ` Arnaldo Carvalho de Melo
2015-09-04 13:42                       ` Adrian Hunter
2015-09-04 14:48                         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440138194-17001-1-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.