From: listmember at orkun.us <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Incorrect flash ids?
Date: Mon, 12 Jan 2004 18:24:04 -0600 (CST) [thread overview]
Message-ID: <14406.216.110.51.8.1073953444.squirrel@www.orkun.us> (raw)
Taken from include/flash.c...
#define INTEL_ID_28F128J3 0x89189818 /* 16M = 8M x 16 x 128 */
#define INTEL_ID_28F320J5 0x00140014 /* 32M = 128K x 32 */
#define INTEL_ID_28F640J5 0x00150015 /* 64M = 128K x 64 */
#define INTEL_ID_28F320J3A 0x00160016 /* 32M = 128K x 32 */
#define INTEL_ID_28F640J3A 0x00170017 /* 64M = 128K x 64 */
#define INTEL_ID_28F128J3A 0x00180018 /* 128M = 128K x 128 */
If I understand correctly, it seems to me that these definitions are
incorrect. I think correct definitions should be as follows:
#define INTEL_ID_28F128J3 0x89188918 /* 16M = 8M x 16 x 128 */
#define INTEL_ID_28F320J5 0x89148914 /* 32M = 128K x 32 */
#define INTEL_ID_28F640J5 0x89158915 /* 64M = 128K x 64 */
#define INTEL_ID_28F320J3A 0x89168916 /* 32M = 128K x 32 */
#define INTEL_ID_28F640J3A 0x89178917 /* 64M = 128K x 64 */
#define INTEL_ID_28F128J3A 0x89188918 /* 128M = 128K x 128 */
#define INTEL_ID_28F256L18T 0x880D880D /* 256M = 128K x 255 + 32k x 4 */
Please note that INTEL_ID_28F128J3 also changed (0x89189818 =>
0x89188918). I think 8 and 9 changed places due to a typo.
Best regards,
Tolunay
Here is the patch:
--- u-boot-1.0.0/include/flash.h 2003-08-29 17:00:48.000000000 -0500
+++ u-boot/include/flash.h 2004-01-12 18:14:33.061103106 -0600
@@ -207,12 +207,12 @@ extern int flash_real_protect(flash_info
#define INTEL_ID_28F640C3T 0x88CC88CC /* 64M = 4M x 16 top boot sector
*/
#define INTEL_ID_28F640C3B 0x88CD88CD /* 64M = 4M x 16 bottom boot
sector */
-#define INTEL_ID_28F128J3 0x89189818 /* 16M = 8M x 16 x 128 */
-#define INTEL_ID_28F320J5 0x00140014 /* 32M = 128K x 32 */
-#define INTEL_ID_28F640J5 0x00150015 /* 64M = 128K x 64 */
-#define INTEL_ID_28F320J3A 0x00160016 /* 32M = 128K x 32 */
-#define INTEL_ID_28F640J3A 0x00170017 /* 64M = 128K x 64 */
-#define INTEL_ID_28F128J3A 0x00180018 /* 128M = 128K x 128 */
+#define INTEL_ID_28F128J3 0x89188918 /* 16M = 8M x 16 x 128 */
+#define INTEL_ID_28F320J5 0x89148914 /* 32M = 128K x 32 */
+#define INTEL_ID_28F640J5 0x89158915 /* 64M = 128K x 64 */
+#define INTEL_ID_28F320J3A 0x89168916 /* 32M = 128K x 32 */
+#define INTEL_ID_28F640J3A 0x89178917 /* 64M = 128K x 64 */
+#define INTEL_ID_28F128J3A 0x89188918 /* 128M = 128K x 128 */
#define INTEL_ID_28F256L18T 0x880D880D /* 256M = 128K x 255 + 32k x 4 */
#define INTEL_ID_28F160S3 0x00D000D0 /* 16M = 512K x 32 (64kB x 32)
*/
next reply other threads:[~2004-01-13 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 0:24 listmember at orkun.us [this message]
2004-01-13 8:55 ` [U-Boot-Users] Incorrect flash ids? Anders Larsen
2004-01-13 9:16 ` listmember at orkun.us
2004-01-13 11:13 ` Anders Larsen
2004-01-13 18:47 ` listmember at orkun.us
2004-01-13 18:54 ` listmember at orkun.us
2004-01-13 18:59 Rune Torgersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14406.216.110.51.8.1073953444.squirrel@www.orkun.us \
--to=listmember@orkun.us \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.