From: Phil Sutter <phil@nwl.cc>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, eric.dumazet@gmail.com, brouer@redhat.com,
geert@linux-m68k.org
Subject: [net-next PATCH 0/4] fixup IFF_NO_QUEUE conversion
Date: Thu, 27 Aug 2015 21:21:35 +0200 [thread overview]
Message-ID: <1440703299-21243-1-git-send-email-phil@nwl.cc> (raw)
This series serves two purposes:
On one hand it fixes a quite embarrassing bug around the warning I added for
drivers still setting tx_queue_len = 0 to achieve noqueue operation. It turned
out to be quite useless as due to using alloc_netdev(), many in-kernel drivers
fell into the trap by accident, as well. Instead this place serves pretty well
as a sanitizing point to set IFF_NO_QUEUE for drivers not initializing
tx_queue_len, which in turn allows to drop all special treatment of the latter
being zero since that can not happen anymore without IFF_NO_QUEUE being set.
On the other hand, it provides a better solution for Eric Dumazet's concern
regarding how to assign noqueue to an interface which does not default to it
already. In order to make this possible, noqueue is being registered so users
can 'tc qd add dev eth0 root noqueue'. In addition, it resolves the ugly
situation of 'tc qd show' not showing noqueue. Finally, the former changes
allow for some code cleanup.
Phil Sutter (4):
net: fix IFF_NO_QUEUE for drivers using alloc_netdev
net: sched: ignore tx_queue_len when assigning default qdisc
net: sched: register noqueue qdisc
net: sched: simplify attach_one_default_qdisc()
include/net/sch_generic.h | 1 +
net/core/dev.c | 2 +-
net/sched/sch_api.c | 1 +
net/sched/sch_generic.c | 54 ++++++++++++++++++++---------------------------
4 files changed, 26 insertions(+), 32 deletions(-)
--
2.1.2
next reply other threads:[~2015-08-27 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 19:21 Phil Sutter [this message]
2015-08-27 19:21 ` [net-next PATCH 1/4] net: fix IFF_NO_QUEUE for drivers using alloc_netdev Phil Sutter
2015-08-27 19:21 ` [net-next PATCH 2/4] net: sched: ignore tx_queue_len when assigning default qdisc Phil Sutter
2015-08-27 19:21 ` [net-next PATCH 3/4] net: sched: register noqueue qdisc Phil Sutter
2015-08-29 20:04 ` Sergei Shtylyov
2015-08-27 19:21 ` [net-next PATCH 4/4] net: sched: simplify attach_one_default_qdisc() Phil Sutter
2015-08-28 0:15 ` [net-next PATCH 0/4] fixup IFF_NO_QUEUE conversion David Miller
2015-09-01 7:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440703299-21243-1-git-send-email-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=geert@linux-m68k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.